Re: Review Request 17483: Support for hbase filters for composite keys

2014-03-03 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review36053 --- Look good. Minor comment on code style. hbase-handler/src/java/org

Re: Review Request 17483: Support for hbase filters for composite keys

2014-03-03 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/ --- (Updated March 3, 2014, 11:40 p.m.) Review request for hive. Changes ---

Re: Review Request 17483: Support for hbase filters for composite keys

2014-01-31 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review2 --- hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableI

Re: Review Request 17483: Support for hbase filters for composite keys

2014-01-31 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review33329 --- hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableI

Re: Review Request 17483: Support for hbase filters for composite keys

2014-01-31 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review33325 --- hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableI

Re: Review Request 17483: Support for hbase filters for composite keys

2014-01-31 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review33313 --- Nice work!! See comments below. hbase-handler/src/java/org/apache/

Review Request 17483: Support for hbase filters for composite keys

2014-01-28 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/ --- Review request for hive. Bugs: HIVE-6290 https://issues.apache.org/jira/bro