Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-26 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15777/#review29453 --- Ship it! Thank you! - Brock Noland On Nov. 22, 2013, 5:52 a.m.,

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-26 Thread Xuefu Zhang
> On Nov. 25, 2013, 11:27 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNegative.java, > > line 85 > > > > > > Runtime exceptions represent problems that are the result of a

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-26 Thread Brock Noland
> On Nov. 25, 2013, 11:27 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNegative.java, > > line 85 > > > > > > Runtime exceptions represent problems that are the result of a

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-25 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15777/#review29406 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloorCe

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-25 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15777/#review29393 --- LGTM, minor issues below. ql/src/java/org/apache/hadoop/hive/ql/ud

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-21 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15777/ --- (Updated Nov. 22, 2013, 5:52 a.m.) Review request for hive. Bugs: HIVE-5706

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-21 Thread Jie Jin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15777/#review29277 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseUna

Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

2013-11-21 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15777/ --- Review request for hive. Summary (updated) - HIVE-5706: Move a