Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-21 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 22, 2013, 1:49 a.m.) Review request for hive. Changes ---

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-21 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 21, 2013, 10:47 p.m.) Review request for hive. Bugs: HIVE-4113

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-21 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 21, 2013, 10:26 p.m.) Review request for hive. Bugs: HIVE-4113

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-20 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 21, 2013, 1:45 a.m.) Review request for hive. Bugs: HIVE-4113

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-20 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 20, 2013, 9:07 p.m.) Review request for hive. Bugs: HIVE-4113

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-20 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 20, 2013, 3:48 p.m.) Review request for hive. Changes ---

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-20 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 20, 2013, 2:24 p.m.) Review request for hive. Changes ---

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-19 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 20, 2013, 3:18 a.m.) Review request for hive. Changes ---

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-19 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/#review26284 --- ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-19 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/#review26274 --- Few comments, mostly around unnecessary null checks, which I think a

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-19 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 19, 2013, 5:48 p.m.) Review request for hive. Bugs: HIVE-4113

Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-18 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- (Updated Sept. 19, 2013, 2:55 a.m.) Review request for hive. Changes ---

Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc

2013-09-18 Thread Yin Huai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ --- Review request for hive. Bugs: HIVE-4113 https://issues.apache.org/jira/bro