Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-17 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review26198 --- Ship it! Ship It! - Thejas Nair On Sept. 18, 2013, 12:41 a.m., X

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-17 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/ --- (Updated Sept. 18, 2013, 12:41 a.m.) Review request for hive and Ashutosh Chauh

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-17 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review26181 --- beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithAr

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-10 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/ --- (Updated Sept. 10, 2013, 9:45 p.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-03 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/ --- (Updated Sept. 4, 2013, 12:15 a.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-03 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review25859 --- beeline/src/java/org/apache/hive/beeline/BeeLine.java

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-08-24 Thread Xuefu Zhang
> On Aug. 22, 2013, 8:09 a.m., Thejas Nair wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 509 > > > > > > I think having this in a function (parseHiveVariables(args) ?) would > > help in keepin

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-08-24 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/ --- (Updated Aug. 24, 2013, 8:19 p.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-08-23 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review25500 --- beeline/src/java/org/apache/hive/beeline/BeeLine.java

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-08-22 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review25408 --- beeline/src/java/org/apache/hive/beeline/BeeLine.java

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-08-20 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/ --- (Updated Aug. 21, 2013, 5:42 a.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-08-14 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/ --- (Updated Aug. 15, 2013, 5:33 a.m.) Review request for hive and Ashutosh Chauhan