Re: Review Request: float and double calculation is inaccurate in Hive

2012-12-21 Thread Mark Grover
> On Dec. 18, 2012, 12:38 a.m., Mark Grover wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java, > > line 50 > > > > > > 10 seems to be a rather arbitrary num

Re: Review Request: float and double calculation is inaccurate in Hive

2012-12-21 Thread Mark Grover
act me offline if you need more details. > > -Bharath > > > From: Johnny Zhang > To: Johnny Zhang ; Mark Grover > ; hive > Sent: Monday, December 17, 2012 5:13 PM > Subject: Re: Review Request: float and double calculation is inaccurate in

Re: Review Request: float and double calculation is inaccurate in Hive

2012-12-18 Thread Bharath Mundlapudi
: float and double calculation is inaccurate in Hive > On Dec. 18, 2012, 12:38 a.m., Mark Grover wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java, > > line 50 > > <https://reviews.apache.org/r/8653/diff/1/?file

Re: Review Request: float and double calculation is inaccurate in Hive

2012-12-17 Thread Johnny Zhang
> On Dec. 18, 2012, 12:38 a.m., Mark Grover wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java, > > line 50 > > > > > > 10 seems to be a rather arbitrary num

Re: Review Request: float and double calculation is inaccurate in Hive

2012-12-17 Thread Johnny Zhang
> On Dec. 18, 2012, 12:38 a.m., Mark Grover wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java, > > line 50 > > > > > > 10 seems to be a rather arbitrary num

Re: Review Request: float and double calculation is inaccurate in Hive

2012-12-17 Thread Mark Grover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8653/#review14625 --- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/ha

Re: Review Request: float and double calculation is inaccurate in Hive

2012-12-17 Thread Johnny Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8653/ --- (Updated Dec. 18, 2012, 12:37 a.m.) Review request for hive. Description (upda

Review Request: float and double calculation is inaccurate in Hive

2012-12-17 Thread Johnny Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8653/ --- Review request for hive. Description --- I found this during debug the e2e