Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/ --- (Updated 2011-12-20 02:05:22.736212) Review request for hive. Changes ---

Re: Review Request: Pass user identity in metastore connection in unsecure mode

I updated the patch incorporating latest Carl's comments. I also added/modified following tests which Carl suggested: Test| Client setugi setting | Server setugi setting TestRemoteHiveMetaStore | false | false TestSetUGIBothClientServer |

Re: Review Request: Pass user identity in metastore connection in unsecure mode

On Dec 19, 2011, at 2:57 PM, Ashutosh Chauhan wrote: > I am not adding any infrastructure in HCatalog. Its already there. I am > just adding tests in it. Adding such an infrastructure is a major > undertaking, which if Hive project agrees could be done. But, thats beyond > the scope of HIVE-2616.

Re: Review Request: Pass user identity in metastore connection in unsecure mode

I am not adding any infrastructure in HCatalog. Its already there. I am just adding tests in it. Adding such an infrastructure is a major undertaking, which if Hive project agrees could be done. But, thats beyond the scope of HIVE-2616. We can do that in followup work. Ashutosh On Mon, Dec 19, 20

Re: Review Request: Pass user identity in metastore connection in unsecure mode

> On 2011-12-19 22:35:15, Ashutosh Chauhan wrote: > > About testing, see my earlier comment. To do any real tests for this, one > > needs to do 'sudo' and then run tests. I have not found an easy way to do > > that in Hive. HCatalog has test infrastructure which makes this kind of > > thing po

Re: Review Request: Pass user identity in metastore connection in unsecure mode

> On 2011-12-19 22:45:48, Carl Steinbach wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java, > > line 279 > > > > > > > you dont want existing application to break when server i

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/#review3987 --- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaSto

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/#review3985 --- About testing, see my earlier comment. To do any real tests for this,

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/#review3984 --- Is it possible to add some testcases? Specifically I'd like to see a t

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/ --- (Updated 2011-12-17 02:42:36.039580) Review request for hive. Changes ---

Re: Review Request: Pass user identity in metastore connection in unsecure mode

> On 2011-12-16 03:06:59, Carl Steinbach wrote: > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 237 > > > > > > All properties that appear in HiveConf also need to appear in > > conf/hive-defaul

Re: Review Request: Pass user identity in metastore connection in unsecure mode

> On 2011-12-16 10:03:39, Thomas wrote: > > Instead of introducing set_ugi into the metastore thrift interface, could > > this not be solved through SASL (looks like a prime use case for SASL)? > > > > Have the server request transmission of ugi when configured to do so and > > the client rea

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/#review3947 --- Ship it! Instead of introducing set_ugi into the metastore thrift int

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/#review3939 --- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/#review3886 --- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaSto

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/ --- (Updated 2011-12-03 00:07:25.189092) Review request for hive. Summary ---

Re: Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/ --- (Updated 2011-12-02 23:46:56.664874) Review request for hive. Changes ---

Review Request: Pass user identity in metastore connection in unsecure mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2975/ --- Review request for hive. Summary --- Pass user identity in metastore connec