Re: Review Request: HIVE-2215

2011-06-15 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/#review843 --- Ship it! Looks good to me. Thanks for making the changes. - Carl On

Re: Review Request: HIVE-2215

2011-06-14 Thread Ashutosh Chauhan
> On 2011-06-14 01:02:20, Carl Steinbach wrote: > > trunk/metastore/if/hive_metastore.thrift, line 46 > > > > > > I think this should be changed to "PartitionEventType" in order to make > > it clear that this applies to pa

Re: Review Request: HIVE-2215

2011-06-14 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/ --- (Updated 2011-06-14 20:51:53.179968) Review request for hive and John Sichi. Ch

Re: Review Request: HIVE-2215

2011-06-13 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/#review824 --- trunk/metastore/if/hive_metastore.thrift

Re: Review Request: HIVE-2215

2011-06-13 Thread Ashutosh Chauhan
> On 2011-06-13 21:47:25, John Sichi wrote: > > trunk/metastore/src/model/package.jdo, line 670 > > > > > > Does indexing actually work on a LONGVARCHAR field across all DB's of > > interest? No, it doesn't. So, I revert

Re: Review Request: HIVE-2215

2011-06-13 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/#review822 --- trunk/metastore/src/model/package.jdo

Review Request: HIVE-2215

2011-06-10 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/ --- Review request for hive and John Sichi. Summary --- Follow-up for HIVE-2147.