Re: Review Request: DB based token store

2012-11-15 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/ --- (Updated Nov. 15, 2012, 9:52 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: DB based token store

2012-11-15 Thread Ashutosh Chauhan
> On Nov. 15, 2012, 6:35 a.m., Mark Grover wrote: > > trunk/metastore/scripts/upgrade/mysql/upgrade-0.9.0-to-0.10.0.mysql.sql, > > line 4 > > > > > > Are the prefix numbers there to keep things sorted in the > > upgrade

Re: Review Request: DB based token store

2012-11-15 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/#review13476 --- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStor

Re: Review Request: DB based token store

2012-11-14 Thread Mark Grover
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/#review13461 --- trunk/metastore/scripts/upgrade/mysql/upgrade-0.9.0-to-0.10.0.mysql.

Re: Review Request: DB based token store

2012-11-13 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/ --- (Updated Nov. 13, 2012, 8:45 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: DB based token store

2012-11-13 Thread Ashutosh Chauhan
> On Nov. 13, 2012, 8:22 a.m., Prasad Mujumdar wrote: > > The patch looks fine to me. > > Just wondering if the new table definitions should also be added to > > hive-schema-0.10.0.XXX.sql files. > > Yeah definitely. My plan is to generate ddl files after all the schema changes are in. I gues

Re: Review Request: DB based token store

2012-11-13 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/#review13387 --- The patch looks fine to me. Just wondering if the new table definiti

Re: Review Request: DB based token store

2012-11-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/ --- (Updated Nov. 12, 2012, 10:54 p.m.) Review request for hive. Changes ---

Review Request: DB based token store

2012-11-07 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/ --- Review request for hive. Description --- DB based token store This addres