Hi all,
HiveQA now gives +1/-1 review based on presence/absence of added or
modified unit tests, like HadoopQA. Obviously not always possible, but
this should be fulfilled to best effort.
Thanks,
Szehon
On Tue, Sep 22, 2015 at 5:37 PM, Sushanth Sowmyan
wrote:
> +1 to Siddharth's suggestion -
+1 to Siddharth's suggestion - it makes it easier on people used to
dealing with other conventions.
On Tue, Sep 22, 2015 at 3:21 PM, Siddharth Seth wrote:
> Can a 'Target Version' field be added to jiras ? That would help to get
> rid of the confusion caused by Fix Version being used to represe
Can a 'Target Version' field be added to jiras ? That would help to get
rid of the confusion caused by Fix Version being used to represent branches
a jira does go into.
On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan
wrote:
> Hi everyone,
>
> Generally, its a good idea to add unit tests in p
Filed HIVE-11913, would be a good task to work on the side.
On Mon, Sep 21, 2015 at 6:17 PM, Szehon Ho wrote:
> Also I think having the HiveQA give -1 without unit test is a good idea,
> we could check for addition or modification of any Test file (Test.*) or
> qtest file.
>
> On Mon, Sep 21, 20
Also I think having the HiveQA give -1 without unit test is a good idea, we
could check for addition or modification of any Test file (Test.*) or qtest
file.
On Mon, Sep 21, 2015 at 2:48 PM, Szehon Ho wrote:
> Good reminder, +1
>
> On Mon, Sep 21, 2015 at 2:33 PM, Thejas Nair
> wrote:
>
>> +1
>
Good reminder, +1
On Mon, Sep 21, 2015 at 2:33 PM, Thejas Nair wrote:
> +1
>
> On a slightly different note, it would also be great if we can plug in
> patch testing that checks for lack of test changes and other issues
> like hadoop has . For example, see -
>
> https://issues.apache.org/jira/br
+1
On a slightly different note, it would also be great if we can plug in
patch testing that checks for lack of test changes and other issues
like hadoop has . For example, see -
https://issues.apache.org/jira/browse/HDFS-9091?focusedCommentId=14791395&page=com.atlassian.jira.plugin.system.issueta
