Re: hi

2013-04-18 Thread Jarek Jarcec Cecho
That makes complete sense to me, so +1 to have the unit tests as strong suggestion rather than constraint. At least for now. Jarcec On Thu, Apr 18, 2013 at 11:24:15AM -0500, Brock Noland wrote: > Agreed, given that most of our tests our existing tests are in .q files, > I'd prefer to see more of

Re: hi

2013-04-18 Thread Brock Noland
Agreed, given that most of our tests our existing tests are in .q files, I'd prefer to see more of a "unit tests highly encouraged" policy as opposed to "must have unit tests". On Thu, Apr 18, 2013 at 11:17 AM, Namit Jain wrote: > Having said that, it might be difficult to write unit tests for

Re: hi

2013-04-18 Thread Namit Jain
Having said that, it might be difficult to write unit tests for operator trees. Might take more time initially - so, making it a constraint might slow us down. On 4/18/13 9:41 PM, "Brock Noland" wrote: >Hi, > >I like the proposal as well! > >On Thu, Apr 18, 2013 at 10:49 AM, Jarek Jarcec Cecho

Re: hi

2013-04-18 Thread Brock Noland
Hi, I like the proposal as well! On Thu, Apr 18, 2013 at 10:49 AM, Jarek Jarcec Cecho wrote: > Hi Namit, > I like your proposal very much and I would take it a bit further: > > > 1. ... For any complex function, clear examples (input/output) would > really help. > > I'm concerned that example

Re: hi

2013-04-18 Thread Namit Jain
Agreed. On 4/18/13 9:19 PM, "Jarek Jarcec Cecho" wrote: >Hi Namit, >I like your proposal very much and I would take it a bit further: > >> 1. ... For any complex function, clear examples (input/output) would >>really help. > >I'm concerned that examples in the code (comments) might very quic

Re: hi

2013-04-18 Thread Jarek Jarcec Cecho
Hi Namit, I like your proposal very much and I would take it a bit further: > 1. ... For any complex function, clear examples (input/output) would > really help. I'm concerned that examples in the code (comments) might very quickly become obsolete as it can very easily happen that someone wi

Re: hi

2013-04-18 Thread Gang Tim Liu
Super like it. On 4/18/13 5:31 AM, "Namit Jain" wrote: >Hi, > >Since we are developing at a very fast pace, it would be really useful to >think about maintainability and testing of the large codebase. >Historically, we have not focussed on a few things, and they might soon >bite us. I wanted to