Re: Review requests for HIVE-22841 and HIVE-22539

2020-03-16 Thread Kevin Risden
Thanks Zoltan for the review. No worries things fall through the cracks all the time. I rebased the patches to make sure they still apply to master. Kevin Risden On Mon, Mar 16, 2020 at 6:35 AM Zoltan Haindrich wrote: > Hey Kevin! > > Unfortunately there are times when I stop checking for tic

Re: Review requests for HIVE-22841 and HIVE-22539

2020-03-16 Thread Zoltan Haindrich
Hey Kevin! Unfortunately there are times when I stop checking for tickets which are waiting for reviews... I think we all might be a little bit busy with all kind of stuff nowadays. Thank you for taking the time and writing this email to draw attention to that your patches are awaiting reviews

Re: Review requests & JIRA process

2014-08-17 Thread Lars Francke
Thanks Sergey, unfortunately it's often not easy to figure that out but I'll try. So, anyone willing to do reviews on these: These are the issues in need of reviews: * (huge but I'd appreciate an answer fast to avoid having to rebase it often) *

Re: Review requests & JIRA process

2014-08-07 Thread Sergey Shelukhin
I think the process that works best for getting patches reviewed is adding specific people to RB/JIRA and asking, usually the people who are active in a related area of code. And nagging them until they either review or refuse to review :) On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke wrote: > H

Re: Review requests & JIRA process

2014-08-07 Thread Lars Francke
Hey, just wanted to bump this in case anyone has any opinions as well as what the procedure is for patches that don't get a review for a longer period of time. I'd like to avoid a lot of unnecessary work on my end :) Cheers, Lars On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke wrote: > Hi everyo

Re: Review Requests

2013-02-20 Thread kulkarni.swar...@gmail.com
Would someone have a chance to take a quick look at these review requests[1][2]. [1] https://reviews.apache.org/r/9275/ [2] https://reviews.apache.org/r/9276/ Thanks, On Tue, Feb 5, 2013 at 10:00 AM, kulkarni.swar...@gmail.com < kulkarni.swar...@gmail.com> wrote: > Thanks Mark. Appreciate that

Re: Review Requests

2013-02-05 Thread kulkarni.swar...@gmail.com
Thanks Mark. Appreciate that. I'll take a look. On Mon, Feb 4, 2013 at 10:23 PM, Mark Grover wrote: > Swarnim, > I left some comments on reviewboard. > > On Mon, Feb 4, 2013 at 8:00 AM, kulkarni.swar...@gmail.com < > kulkarni.swar...@gmail.com> wrote: > > > Hello, > > > > I opened up two review

Re: Review Requests

2013-02-04 Thread Mark Grover
Swarnim, I left some comments on reviewboard. On Mon, Feb 4, 2013 at 8:00 AM, kulkarni.swar...@gmail.com < kulkarni.swar...@gmail.com> wrote: > Hello, > > I opened up two reviews for small issues, HIVE-3553[1] and HIVE-3725[2]. If > you guys get a chance to review and provide feedback on it, I w