Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/#review211519 --- Ship it! Ship It! - Eugene Koifman On Dec. 21, 2018, 4:30 p.

Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Jaume Marhuenda
> On Dec. 21, 2018, 8:57 p.m., Eugene Koifman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionInfo.java > > Line 34 (original), 42 (patched) > > > > > >

Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Jaume Marhuenda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/ --- (Updated Dec. 22, 2018, 12:30 a.m.) Review request for hive. Repository: hive

Re: Review Request 69462: HIVE-20936

2018-12-21 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/#review211508 --- it looks like it has merge conflits standalone-metastore/metasto

Re: Review Request 69462: HIVE-20936

2018-12-20 Thread Jaume Marhuenda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/ --- (Updated Dec. 21, 2018, 1:02 a.m.) Review request for hive. Repository: hive-

Re: Review Request 69462: HIVE-20936

2018-12-17 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/#review211381 --- ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java L

Re: Review Request 69462: HIVE-20936

2018-12-17 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/#review211379 --- standalone-metastore/metastore-common/src/main/java/org/apache/ha

Re: Review Request 69462: HIVE-20936

2018-12-17 Thread Jaume Marhuenda
> On Dec. 13, 2018, 12:04 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java > > Line 97 (original), 94 (patched) > > > > > > this is also intialzied in init() - should it

Re: Review Request 69462: HIVE-20936

2018-12-17 Thread Jaume Marhuenda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/ --- (Updated Dec. 17, 2018, 5:59 p.m.) Review request for hive. Repository: hive-

Re: Review Request 69462: HIVE-20936

2018-12-12 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/#review211256 --- ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorThre

Re: Review Request 69462: HIVE-20936

2018-12-11 Thread Jaume Marhuenda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69462/ --- (Updated Dec. 11, 2018, 11:45 p.m.) Review request for hive. Repository: hive