Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/ --- (Updated Oct. 31, 2017, 9:13 p.m.) Review request for hive and Prasanth_J. Re

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/ --- (Updated Oct. 31, 2017, 6:54 p.m.) Review request for hive and Prasanth_J. Re

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189491 --- Ship it! Ship It! - Prasanth_J On Oct. 27, 2017, 10:10 p.m.,

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/ --- (Updated Oct. 27, 2017, 10:10 p.m.) Review request for hive and Prasanth_J. R

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

> On Oct. 27, 2017, 6:24 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > > Lines 1306 (patched) > > > > > > nit: do we know the reason why? may be print some user

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189459 --- JIRA is down for indexing. Mostly the changes look good. Left some

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

> On Oct. 25, 2017, 9:57 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > > Lines 130 (patched) > > > > > > use notEmpty.awaitUninterruptibly() ? won't wake up for spur

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189456 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

> On Oct. 25, 2017, 9:57 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > > Line 98 (original), 110 (patched) > > > > > > would be cleaner with executor service + threa

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189450 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.ja

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/ --- (Updated Oct. 27, 2017, 2:43 a.m.) Review request for hive and Prasanth_J. Re

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

> On Oct. 25, 2017, 9:57 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > > Line 88 (original), 100 (patched) > > > > > > nit: <=1 ? there's a check on the previous li

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

> On Oct. 27, 2017, 12:25 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > > Lines 120 (patched) > > > > > > Alternatively, since you are not looking at return value an

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189373 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.jav

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189249 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationMan

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/#review189124 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.ja

Re: Review Request 63230: HIVE-17841 implement applying the resource plan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63230/ --- (Updated Oct. 24, 2017, 11:58 p.m.) Review request for hive and Prasanth_J. R