Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59998/#review178517 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/OperatorComparato

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59998/ --- (Updated June 21, 2017, 3:44 p.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59998/#review178499 --- ql/src/test/results/clientpositive/perf/query94.q.out Lines 89-96

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Ashutosh Chauhan
> On June 21, 2017, 2:03 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/except_distinct.q.out > > Lines 421-425 (original), 413-417 (patched) > > > > > > Missed opportunity. Could have remo

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59998/#review178496 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line 16

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Jesús Camacho Rodríguez
> On June 21, 2017, 2:03 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/except_distinct.q.out > > Lines 421-425 (original), 413-417 (patched) > > > > > > Missed opportunity. Could have remo

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59998/ --- (Updated June 21, 2017, 9:06 a.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 59998: HIVE-16867

2017-06-21 Thread Jesús Camacho Rodríguez
> On June 21, 2017, 2:03 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedScanOptimizer.java > > Line 77 (original), 108 (patched) > > > > > > Shall rename this to SharedWorkOpt

Re: Review Request 59998: HIVE-16867

2017-06-20 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59998/#review178443 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedScanOptimiz