Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-28 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/ --- (Updated Feb. 28, 2017, 10:28 a.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-27 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review166945 --- LGTM (non-binding). Just one comment below. Thanks Peter! itests

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-24 Thread Peter Vary
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/util/QFileClient.java, line 125 > > > > > > can you please add a comment saying what the filter regex is doing t

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-24 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/ --- (Updated Feb. 24, 2017, 12:21 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-23 Thread Peter Vary
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, > > lines 66-68 > > > > > > Not sure why we need this? Can you pleas

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-22 Thread Peter Vary
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, > > lines 81-86 > > > > > > Is it possible to use miniHS2 instead? >

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-20 Thread Vihang Karajgaonkar
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, > > line 116 > > > > > > Having a fixed port number could become a

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-20 Thread Peter Vary
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/util/QFileClient.java, line 125 > > > > > > can you please add a comment saying what the filter regex is doing t

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-18 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review166031 --- beeline/src/java/org/apache/hive/beeline/util/QFileClient.java (l

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2016-10-19 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/ --- (Updated Oct. 19, 2016, 1:39 p.m.) Review request for hive, Zoltan Haindrich, M

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2016-10-18 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/ --- (Updated Oct. 18, 2016, 2:54 p.m.) Review request for hive, Zoltan Haindrich, M

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2016-10-18 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review153051 --- Ship it! Thanks for the patch. +1 - Barna Zsombor Klara On O

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2016-10-18 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review153046 --- Ship it! Hello Peter! Beeline tests are coming back into busin