Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-11 Thread Simanchal Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49619/ --- (Updated July 11, 2016, 1:32 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-11 Thread Simanchal Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49619/ --- (Updated July 11, 2016, 8:37 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-11 Thread Simanchal Das
> On July 9, 2016, 8:53 p.m., Carl Steinbach wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArrayByField.java, > > line 56 > > > > > > A couple notes: > > > > 1. I think the examp

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-09 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49619/#review141413 --- Some more comments. ql/src/java/org/apache/hadoop/hive/ql/udf/ge

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-08 Thread Simanchal Das
> On July 7, 2016, 6:45 a.m., Carl Steinbach wrote: > > ql/src/test/results/beelinepositive/show_functions.q.out, line 183 > > > > > > The number of rows is off by 8. This looks like a bug, thought not one > > cause

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-08 Thread Simanchal Das
> On July 7, 2016, 6:45 a.m., Carl Steinbach wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 427 > > > > > > To me "sort_array_field" makes it sound like this function sorts the > >

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-08 Thread Simanchal Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49619/ --- (Updated July 8, 2016, 12:35 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-06 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49619/#review141130 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java

Re: Review Request 49619: sorting of tuple array using multiple fields

2016-07-06 Thread Simanchal Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49619/ --- (Updated July 7, 2016, 5:03 a.m.) Review request for hive and Carl Steinbach.