Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41062/#review109581 --- Ship it! LGTM - Mohit Sabharwal On Dec. 9, 2015, 4:35 p.m., Jim

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41062/ --- (Updated Dec. 9, 2015, 4:35 p.m.) Review request for hive, Szehon Ho and Xuefu

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

> On Dec. 8, 2015, 10:43 p.m., Szehon Ho wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1861 > > > > > > We can keep it lower-case to keep it consistent. > > Jimmy Xiang wrote: > I t

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

> On Dec. 8, 2015, 10:10 p.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hive/http/HttpServer.java, line 93 > > > > > > should this be conditional on the cluster itself being kerberized ? > > > >

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

> On Dec. 8, 2015, 10:43 p.m., Szehon Ho wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1861 > > > > > > We can keep it lower-case to keep it consistent. I thought about this too. We hav

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41062/#review109419 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 18

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41062/#review109411 --- common/src/java/org/apache/hive/http/HttpServer.java (line 93)