Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review109414 --- Ship it! Looks good. Small nits in the last patch - mostly around

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review109413 --- Ship it! Ship It! - Siddharth Seth On Dec. 5, 2015, 9:40 p.m.,

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review109407 --- llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceI

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Dec. 5, 2015, 9:40 p.m.) Review request for hive, Gopal V and Siddhart

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Dec. 3, 2015, 11:07 p.m.) Review request for hive, Gopal V and Siddhar

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review108467 --- Ship it! Ship It! - Lefty Leverenz On Nov. 30, 2015, 7:50 p.m.,

Re: Review Request 40315: HIVE-12341 LLAP security

> On Nov. 30, 2015, 7:49 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2377-2378 > > > > > > Should this have a TimeValidator (like the next two Spark parameters,

Re: Review Request 40315: HIVE-12341 LLAP security

> On Nov. 30, 2015, 7:49 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2377-2378 > > > > > > Should this have a TimeValidator (like the next two Spark parameters,

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Nov. 30, 2015, 7:50 p.m.) Review request for hive, Gopal V and Siddhar

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review108296 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Nov. 26, 2015, 1:38 a.m.) Review request for hive, Gopal V and Siddhar

Re: Review Request 40315: HIVE-12341 LLAP security

> On Nov. 24, 2015, 3:56 a.m., Siddharth Seth wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2361 > > > > > > Don't think the default value - "*" - has any significance here. > > Replace

Re: Review Request 40315: HIVE-12341 LLAP security

> On Nov. 24, 2015, 3:56 a.m., Siddharth Seth wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2361 > > > > > > Don't think the default value - "*" - has any significance here. > > Replace

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review107877 --- - Siddharth Seth On Nov. 24, 2015, 11:11 p.m., Sergey Shelukhin w

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review107870 --- Token and credentials usage looks good to me. Looking at other revi

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Nov. 24, 2015, 11:11 p.m.) Review request for hive, Gopal V and Siddha

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Nov. 24, 2015, 11:08 p.m.) Review request for hive, Gopal V and Siddha

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Nov. 24, 2015, 11:06 p.m.) Review request for hive, Gopal V and Siddha

Re: Review Request 40315: HIVE-12341 LLAP security

> On Nov. 24, 2015, 3:56 a.m., Siddharth Seth wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2361 > > > > > > Don't think the default value - "*" - has any significance here. > > Replace

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review107706 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 23

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/#review107670 --- llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapUm

Re: Review Request 40315: HIVE-12341 LLAP security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40315/ --- (Updated Nov. 16, 2015, 7:45 p.m.) Review request for hive, Gopal V and Siddhar