Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver

2015-05-29 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34727/#review85821 --- Ship it! Ship It! - Vaibhav Gumashta On May 29, 2015, 9:42 p.m.,

Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver

2015-05-29 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34727/ --- (Updated May 29, 2015, 9:42 p.m.) Review request for hive, Szehon Ho, Thejas Na

Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver

2015-05-29 Thread Vaibhav Gumashta
> On May 29, 2015, 7:51 p.m., Vaibhav Gumashta wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java, > > line 126 > > > > > > Test looks good. Can you also add a Statement#cancel in

Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver

2015-05-29 Thread Chaoyu Tang
> On May 29, 2015, 7:51 p.m., Vaibhav Gumashta wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java, > > line 126 > > > > > > Test looks good. Can you also add a Statement#cancel in

Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver

2015-05-29 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34727/#review85782 --- itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMin

Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver

2015-05-29 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34727/ --- (Updated May 29, 2015, 11:44 a.m.) Review request for hive, Szehon Ho, Thejas N

Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver

2015-05-28 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34727/ --- (Updated May 28, 2015, 2:48 p.m.) Review request for hive, Szehon Ho, Thejas Na