Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 17, 2015, 12:19 a.m., Xuefu Zhang wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java, > > line 179 > > > > > > Sorry I didn't get it, but why? > > Clarity but not per

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 17, 2015, 12:19 a.m., Xuefu Zhang wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java, > > line 179 > > > > > > Sorry I didn't get it, but why? > > Clarity but not per

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 17, 2015, 12:19 a.m., Xuefu Zhang wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java, > > line 179 > > > > > > Sorry I didn't get it, but why? > > Clarity but not per

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29954/#review68513 --- spark-client/src/main/java/org/apache/hive/spark/client/JobHandleIm

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29954/ --- (Updated Jan. 16, 2015, 11:24 p.m.) Review request for hive, Brock Noland, chen

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 16, 2015, 10:35 p.m., Xuefu Zhang wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java, > > line 179 > > > > > > Here sparkJobIds.add() is in the synchronized block. Howeve

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 16, 2015, 10:35 p.m., Xuefu Zhang wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java, > > line 179 > > > > > > Here sparkJobIds.add() is in the synchronized block. Howeve

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 16, 2015, 10:35 p.m., Xuefu Zhang wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java, > > line 179 > > > > > > Here sparkJobIds.add() is in the synchronized block. Howeve

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29954/#review68492 --- spark-client/src/main/java/org/apache/hive/spark/client/JobHandleIm

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29954/ --- (Updated Jan. 16, 2015, 9:22 p.m.) Review request for hive, Brock Noland, cheng

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 16, 2015, 7:14 p.m., Xuefu Zhang wrote: > > One additional question for my understanding: > > > > Originally Hive has to poll to get job ID after submitting a spark job, in > > RemoteSparkJobStatus.getSparkJobInfo(). With this patch, do we still need > > to do this. > > Marcelo Vanz

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

> On Jan. 16, 2015, 7:14 p.m., Xuefu Zhang wrote: > > One additional question for my understanding: > > > > Originally Hive has to poll to get job ID after submitting a spark job, in > > RemoteSparkJobStatus.getSparkJobInfo(). With this patch, do we still need > > to do this. Yeah, that's sti

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29954/#review68430 --- One additional question for my understanding: Originally Hive has t

Re: Review Request 29954: HIVE-9179. Add listener API to JobHandle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29954/#review68392 --- Ship it! Ship It! - chengxiang li On 一月 16, 2015, 1:05 a.m., Mar