Re: Review Request 28510: HIVE-8974

2014-12-05 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/#review64061 --- Ship it! Ship It! - John Pullokkaran On Dec. 3, 2014, 12:45 a.m.

Re: Review Request 28510: HIVE-8974

2014-12-05 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/#review64052 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Dec. 3, 2014, 12:

Re: Review Request 28510: HIVE-8974

2014-12-02 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/ --- (Updated Dec. 3, 2014, 12:45 a.m.) Review request for hive, John Pullokkaran an

Re: Review Request 28510: HIVE-8974

2014-12-02 Thread Jesús Camacho Rodríguez
> On Dec. 1, 2014, 11:45 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java, > > line 1 > > > > > > Why can't we reuse HiveAggregateRel? We reuse i

Re: Review Request 28510: HIVE-8974

2014-12-01 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/#review63461 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperator

Re: Review Request 28510: HIVE-8974

2014-12-01 Thread Julian Hyde
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/#review63433 --- Ship it! Ship It! - Julian Hyde On Nov. 27, 2014, 2:37 p.m., Jes

Re: Review Request 28510: HIVE-8974

2014-11-27 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/ --- (Updated Nov. 27, 2014, 2:37 p.m.) Review request for hive, John Pullokkaran an