Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-11 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Feb. 12, 2015, 4:25 a.m.) Review request for hive, Navis Ryu and Theja

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-11 Thread Navis Ryu
> On Feb. 11, 2015, 12:39 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java, line 265 > > > > > > remove spaces pls done > On Feb. 11, 2015, 12:39 a.m., Alexander Pivo

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-11 Thread Navis Ryu
> On Feb. 11, 2015, 12:49 a.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 341 > > > > > > What you think about adding 2 static wrapper methods registerUDF and

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-10 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review71893 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-10 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review71887 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-09 Thread Navis Ryu
> On Feb. 9, 2015, 9:46 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 1970 > > > > > > Looks like this version of registerTemporaryUDF() is unnecessary, and > > wh

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review71702 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Feb. 9, 2015, 6:56 p.m.) Review request for hive, Navis Ryu and Thejas

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-08 Thread Navis Ryu
> On Nov. 14, 2014, 9:24 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 1626 > > > > > > The message here should be "reload function statement" Fixed > On Nov. 14, 2014,

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-11-14 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review61331 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-11-13 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Nov. 13, 2014, 10:15 p.m.) Review request for hive, Navis Ryu and Thej

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-31 Thread Jason Dere
> On Oct. 23, 2014, 9:50 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java, line 465 > > > > > > There is no longer a way to query the metastore for UDFs apart from the > > static

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-30 Thread Navis Ryu
> On Oct. 31, 2014, 1:32 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 1594 > > > > > > Are these changes meant for this Jira? > > > > Hmm, I think I see why - h

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-30 Thread Navis Ryu
> On Oct. 23, 2014, 9:50 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java, line 465 > > > > > > There is no longer a way to query the metastore for UDFs apart from the > > static

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-30 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review59281 --- Still have the concerns from one of the previous review comments tha

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-30 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Oct. 30, 2014, 11:41 p.m.) Review request for hive, Navis Ryu and Thej

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-24 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Oct. 24, 2014, 5:34 p.m.) Review request for hive, Navis Ryu and Theja

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-24 Thread Jason Dere
> On Oct. 23, 2014, 9:50 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java, line 465 > > > > > > There is no longer a way to query the metastore for UDFs apart from the > > static

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-23 Thread Navis Ryu
> On Oct. 23, 2014, 9:50 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java, line 42 > > > > > > Can we replace isNative/isPersistent with an enum that has BUILTIN, > > PERMANENT

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-23 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review57952 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-22 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Oct. 23, 2014, 12:20 a.m.) Review request for hive, Navis Ryu and Thej

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-20 Thread Thejas Nair
> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > ql/src/test/results/clientpositive/show_functions.q.out, line 21 > > > > > > we need to document that windowing functions show up with "@_" prefix > > in 'show_func

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-20 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review57443 --- itests/hive-unit/src/test/java/org/apache/hive/service/TestHiveServ

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-20 Thread Jason Dere
> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/service/TestHiveServerSessions.java, > > line 61 > > > > > > should we use hiveserver2 (/minish2) instead since that

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-20 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Oct. 20, 2014, 6:28 p.m.) Review request for hive, Navis Ryu and Theja

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-18 Thread Lefty Leverenz
> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > ql/src/test/results/clientpositive/show_functions.q.out, line 21 > > > > > > we need to document that windowing functions show up with "@_" prefix > > in 'show_func

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-18 Thread Thejas Nair
> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > ql/src/test/results/clientpositive/show_functions.q.out, line 21 > > > > > > we need to document that windowing functions show up with "@_" prefix > > in 'show_func

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-18 Thread Lefty Leverenz
> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > ql/src/test/results/clientpositive/show_functions.q.out, line 21 > > > > > > we need to document that windowing functions show up with "@_" prefix > > in 'show_func

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-18 Thread Lefty Leverenz
> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > ql/src/test/results/clientpositive/show_functions.q.out, line 21 > > > > > > we need to document that windowing functions show up with "@_" prefix > > in 'show_func

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-18 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review57232 --- itests/hive-unit/src/test/java/org/apache/hive/service/TestHiveServ

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-16 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/ --- (Updated Oct. 17, 2014, 2:21 a.m.) Review request for hive. Bugs: HIVE-2573