Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/ --- (Updated July 7, 2014, 7:41 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/ --- (Updated July 2, 2014, 6:23 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

> On July 2, 2014, 2:07 a.m., Brock Noland wrote: > > Hey Jason, looks good! Nice work! I have a question or two below and a bit > > nits. Thanks for reviewing! > On July 2, 2014, 2:07 a.m., Brock Noland wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java, >

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/#review47170 --- Hey Jason, looks good! Nice work! I have a question or two below and

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

> On June 30, 2014, 6:48 p.m., Alan Gates wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 293 > > > > > > Same as comment above on being able to create a temp table

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

> On June 30, 2014, 6:48 p.m., Alan Gates wrote: > > What will happen if a user tries to create a view over a temp table? I'm > > not sure if the creation will fail (since there's no table in the database) > > or succeed but fail later when the user tries to use the view. Ideally it > > woul

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/#review47005 --- What will happen if a user tries to create a view over a temp table?

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/ --- (Updated June 28, 2014, 12:35 a.m.) Review request for hive, Gunther Hagleitner

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

> On June 26, 2014, 4:26 a.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Context.java, line 76 > > > > > > What is the purpose of removing from here? I don't see any other > > changes? Looks like t

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

> On June 26, 2014, 4:21 a.m., Brock Noland wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java, > > line 238 > > > > > > We should be checking for something more specific than a sql

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/#review46713 --- ql/src/java/org/apache/hadoop/hive/ql/Context.java

Re: Review Request 22996: HIVE-7090 Support session-level temporary tables in Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22996/#review46712 --- itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMin