Re: Review Request 21841: Hive should support adding multiple resources at once

2014-05-26 Thread Navis Ryu
> On May 23, 2014, 3:06 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java, > > line 57 > > > > > > Why do we need to make a copy? Just wanted to exclude first token

Re: Review Request 21841: Hive should support adding multiple resources at once

2014-05-22 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21841/#review43807 --- ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcess

Re: Review Request 21841: Hive should support adding multiple resources at once

2014-05-22 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21841/#review43808 --- Good change, left some minor code considerations. - Szehon Ho On