Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-06 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review36492 --- Ship it! Ship It! - Thejas Nair On March 7, 2014, 1:17 a.m., Nav

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/ --- (Updated March 7, 2014, 1:17 a.m.) Review request for hive. Changes ---

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-06 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review36359 --- ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-06 Thread Thejas Nair
> On Feb. 27, 2014, 11:08 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java, line 110 > > > > > > When pollFinished is running, this shutdown() function will not be able > > to make

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-04 Thread Navis Ryu
> On Feb. 27, 2014, 11:08 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java, line 110 > > > > > > When pollFinished is running, this shutdown() function will not be able > > to make

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-04 Thread Thejas Nair
> On Feb. 27, 2014, 11:08 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java, line 110 > > > > > > When pollFinished is running, this shutdown() function will not be able > > to make

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-04 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/ --- (Updated March 4, 2014, 8:02 a.m.) Review request for hive. Changes ---

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-04 Thread Navis Ryu
> On Feb. 27, 2014, 11:08 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java, line 110 > > > > > > When pollFinished is running, this shutdown() function will not be able > > to make

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-02-27 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review35625 --- ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-02-26 Thread Navis Ryu
> On Feb. 25, 2014, 4:25 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java, line 44 > > > > > > Thanks for doing this. Its much cleaner with this change! Thanks. - Navis ---

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-02-26 Thread Navis Ryu
> On Feb. 25, 2014, 4:10 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java, line 51 > > > > > > We should make this volatile, another thread calling shutdown might > > otherwise it i

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-02-26 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/ --- (Updated Feb. 27, 2014, 7:06 a.m.) Review request for hive. Changes ---

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-02-24 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review35371 --- ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-02-24 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review35325 --- ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-01-05 Thread Navis Ryu
> On Jan. 2, 2014, 5:37 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1347 > > > > > > wouldn't this be true in case of many error paths above? > > Where driverCxt.shut

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-01-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review31039 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java

Re: Review Request 15873: Query cancel should stop running MR tasks

2013-12-29 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/ --- (Updated Dec. 30, 2013, 6:57 a.m.) Review request for hive. Changes ---