Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
> On Nov. 7, 2013, 3:52 a.m., Thejas Nair wrote: > > conf/hive-default.xml.template, line 1907 > > > > > > I will take care of this white space before commit. > > Sorry, fixed it. - Vaibhav --

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/ --- (Updated Nov. 7, 2013, 4:12 a.m.) Review request for hive and Thejas Nair. Ch

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review28351 --- Ship it! Ship It! - Thejas Nair On Nov. 6, 2013, 11:14 p.m., Vai

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review28350 --- conf/hive-default.xml.template

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/ --- (Updated Nov. 6, 2013, 11:14 p.m.) Review request for hive and Thejas Nair. C

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review28328 --- service/src/java/org/apache/hive/service/cli/session/SessionManager

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review28320 --- Nice work!! just noting there is some lint issues with whitespace.

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/ --- (Updated Nov. 6, 2013, 9:46 p.m.) Review request for hive and Thejas Nair. Ch

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-10-24 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review27464 --- service/src/java/org/apache/hive/service/cli/session/SessionManager

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-10-24 Thread Thejas Nair
> On Oct. 24, 2013, 8:43 a.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java, > > line 69 > > > > > > The timeout is applicable only if the number of threads are more t

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-10-24 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review27449 --- service/src/java/org/apache/hive/service/cli/session/SessionManager