Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2014-05-13 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ --- (Updated May 9, 2014, 12:23 a.m.) Review request for hive, Ashutosh Chauhan and

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2014-05-06 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ --- (Updated May 6, 2014, 10:06 p.m.) Review request for hive, Ashutosh Chauhan and

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2014-01-30 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ --- (Updated Jan. 31, 2014, 2:18 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2014-01-30 Thread Mohammad Islam
> On Jan. 11, 2014, 8:05 a.m., Carl Steinbach wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java, > > line 146 > > > > > > wrapWithUnion is not used. Used in updated code. > On Jan.

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2014-01-11 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/#review31584 --- ql/src/test/queries/clientpositive/avro_create_as_select.q

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2014-01-10 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/#review31583 --- ql/src/test/queries/clientpositive/avro_create_as_select.q

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2014-01-10 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ --- (Updated Jan. 10, 2014, 7:58 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-11-12 Thread Mohammad Islam
> On July 29, 2013, 5:41 p.m., Jakob Homan wrote: > > There is still no text covering a map-reduce job on an already existing, > > non-Avro table into an avro table. ie, create a text table, populate it, > > run a CTAS to manipulate the data into an Avro table. > > Mohammad Islam wrote: >

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-08-25 Thread Jakob Homan
> On July 29, 2013, 10:41 a.m., Jakob Homan wrote: > > There is still no text covering a map-reduce job on an already existing, > > non-Avro table into an avro table. ie, create a text table, populate it, > > run a CTAS to manipulate the data into an Avro table. > > Mohammad Islam wrote: >

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-08-07 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ --- (Updated Aug. 8, 2013, 12:24 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-29 Thread Mohammad Islam
> On July 29, 2013, 5:41 p.m., Jakob Homan wrote: > > There is still no text covering a map-reduce job on an already existing, > > non-Avro table into an avro table. ie, create a text table, populate it, > > run a CTAS to manipulate the data into an Avro table. In general, Hive creates "inter

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-29 Thread Jakob Homan
> On June 29, 2013, 7:43 p.m., Ashutosh Chauhan wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java, line > > 70 > > > > > > I think determining schema from table definition should be defau

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-29 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/#review24149 --- There is still no text covering a map-reduce job on an already exist

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-23 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ --- (Updated July 23, 2013, 9:51 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-22 Thread Mohammad Islam
> On July 12, 2013, 10:32 p.m., Jakob Homan wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java, line > > 67 > > > > > > Should be a debug Done > On July 12, 2013, 10:32 p.m., Jakob Homa

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-12 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/#review23102 --- Overall, looks good. I'm concerned that there's no end-to-end test

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-12 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ --- (Updated July 12, 2013, 6:49 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-07-12 Thread Mohammad Islam
> On June 30, 2013, 2:43 a.m., Ashutosh Chauhan wrote: > > Can you also run all new tests with ant test -Dhadoop.mr.rev=23 to make > > sure we are getting right results. Else, you might need to add more columns > > in order-by columns. Tested > On June 30, 2013, 2:43 a.m., Ashutosh Chauhan w

Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables

2013-06-29 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/#review22571 --- Can you also run all new tests with ant test -Dhadoop.mr.rev=23 to m