Re: Review Request: Vectorized Timestamp functions for long nanosecond based timestamps

2013-05-31 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11530/#review21261 --- Ship it! Ship It! - Eric Hanson On May 31, 2013, 1:59 p.m., Gopa

Re: Review Request: Vectorized Timestamp functions for long nanosecond based timestamps

2013-05-31 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11530/ --- (Updated May 31, 2013, 1:59 p.m.) Review request for hive, Jitendra Pandey and

Re: Review Request: Vectorized Timestamp functions for long nanosecond based timestamps

2013-05-31 Thread Gopal V
> On May 30, 2013, 9:29 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFTimestampFieldLong.java, > > line 56 > > > > > > If you know in what cases ms can be negative,

Re: Review Request: Vectorized Timestamp functions for long nanosecond based timestamps

2013-05-30 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11530/#review21203 --- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/Vecto