Re: Review Request: Input Sampling Splits

2011-04-28 Thread namit jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/633/#review605 --- trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.ja

Re: Review Request: Input Sampling Splits

2011-04-28 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/633/ --- (Updated 2011-04-28 08:32:17.534107) Review request for hive, Ning Zhang and nami

Re: Review Request: Input Sampling Splits

2011-04-26 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/633/#review567 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.j

Re: Review Request: Input Sampling Splits

2011-04-26 Thread Ning Zhang
> On 2011-04-26 20:50:30, Siying Dong wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, > > line 498 > > > > > > I feel like it is a little hard to explain what this sample guarantees. >

Re: Review Request: Input Sampling Splits

2011-04-26 Thread Siying Dong
> On 2011-04-26 20:50:30, Siying Dong wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, > > line 498 > > > > > > I feel like it is a little hard to explain what this sample guarantees. >

Re: Review Request: Input Sampling Splits

2011-04-26 Thread Ning Zhang
> On 2011-04-26 20:50:30, Siying Dong wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, > > line 498 > > > > > > I feel like it is a little hard to explain what this sample guarantees. >

Re: Review Request: Input Sampling Splits

2011-04-26 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/633/ --- (Updated 2011-04-26 21:19:18.557345) Review request for hive, Ning Zhang and nami

Re: Review Request: Input Sampling Splits

2011-04-26 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/633/#review561 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

Re: Review Request: Input Sampling Splits

2011-04-26 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/633/#review558 --- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java