Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-17 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-17 21:19:30.440767) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-07 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-07 17:36:59.604078) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-06 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-06 21:16:11.713258) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-05 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-05 23:32:22.234376) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-04 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-04 17:46:49.734706) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-03 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/#review2291 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-03 Thread Jonathan Chang
> On 2011-10-03 18:36:46, Igor Kabiljo wrote: > > looks good!! Um, @jvs, how do I shipit? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/#review2275 -

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-03 Thread Igor Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/#review2275 --- Ship it! looks good!! - Igor On 2011-10-03 18:35:09, Jonathan Chan

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-03 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-03 18:35:09.336203) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-03 Thread Igor Kabiljo
> On 2011-10-03 08:31:46, Igor Kabiljo wrote: > > Nice, this is even better then what I thought. > > > > This now supports all OIs, except for struct and unions, right? No reason > > not to add structs, should we add both? > > Also, should we change so that every VoidObjectInspector is constant

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-03 Thread Jonathan Chang
> On 2011-10-03 08:31:46, Igor Kabiljo wrote: > > Nice, this is even better then what I thought. > > > > This now supports all OIs, except for struct and unions, right? No reason > > not to add structs, should we add both? > > Also, should we change so that every VoidObjectInspector is constant

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-03 Thread Igor Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/#review2259 --- Nice, this is even better then what I thought. This now supports all

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-02 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-03 01:36:16.628780) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-10-02 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-10-03 01:31:21.490736) Review request for hive, Carl Steinbach, Jo

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-09-28 Thread Igor Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/#review2142 --- Everything looks great, this will be really helpful! Just few inline c

Re: Review Request: Improve support for ConstantObjectInspectors in Hive

2011-09-27 Thread Jonathan Chang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2078/ --- (Updated 2011-09-27 23:03:09.601042) Review request for hive, Carl Steinbach, Jo