Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

2012-09-11 Thread Feng Peng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7024/#review11355 --- lgtm. non-committer +1 - Feng Peng On Sept. 11, 2012, 6:30 p.m., T

Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

2012-09-11 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7024/ --- (Updated Sept. 11, 2012, 6:30 p.m.) Review request for hive, Ashutosh Chauhan, D

Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

2012-09-11 Thread Travis Crawford
> On Sept. 11, 2012, 5:47 p.m., Feng Peng wrote: > > build.xml, line 23 > > > > > > Any reason for this change? I changed the "urn" lines after reading http://maven.apache.org/ant-tasks/installation.html The following

Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

2012-09-11 Thread Feng Peng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7024/#review11340 --- build.xml Any

Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

2012-09-11 Thread Travis Crawford
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7024/ --- (Updated Sept. 11, 2012, 5:21 p.m.) Review request for hive, Ashutosh Chauhan, D