Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-08-10 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-08-10 23:53:23.261081) Review request for hive, Yongqiang He, Ning

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-08-10 Thread Franklin Hu
> On 2011-08-10 21:30:23, Ashutosh Chauhan wrote: > > trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java, > > line 134 > > > > > > I think you want Arrays.equals() there. currentBytes always po

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-08-10 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/#review1391 --- trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritab

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-08-08 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-08-08 18:19:27.210647) Review request for hive, Yongqiang He, Ning

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-08-05 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/#review1277 --- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-07-28 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 21:59:38.146393) Review request for hive, Yongqiang He, Ning

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-07-28 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 20:51:48.675604) Review request for hive, Yongqiang He, Ning

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-07-28 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-28 19:17:59.868991) Review request for hive. Changes ---

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-07-26 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-26 21:11:35.218104) Review request for hive. Changes ---

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-07-18 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-18 19:13:31.962359) Review request for hive. Summary ---

Re: Review Request: HIVE-2272: add TIMESTAMP data type

2011-07-18 Thread Franklin Hu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1135/ --- (Updated 2011-07-18 19:12:08.745755) Review request for hive. Summary (updated