Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-30 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10712/#review19973 --- Ship it! Ship It! - Ashutosh Chauhan On April 25, 2013, 1 a.m.,

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-24 Thread Sarvesh Sakalanaga
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10712/ --- (Updated April 25, 2013, 1 a.m.) Review request for hive. Changes --- Ad

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-24 Thread Sarvesh Sakalanaga
> On April 24, 2013, 11:01 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerReader.java, > > line 97 > > > > > > if there are no nulls in a strip or split for a column, we shoul

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-24 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10712/#review19674 --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-24 Thread Sarvesh Sakalanaga
> On April 23, 2013, 7:33 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReader.java, line 47 > > > > > > the previous argument and the return value are always of class > > VectorizedRo

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-24 Thread Sarvesh Sakalanaga
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10712/ --- (Updated April 24, 2013, 9:53 p.m.) Review request for hive. Changes ---

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-24 Thread Sarvesh Sakalanaga
> On April 23, 2013, 2:31 p.m., Scott Preece wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/DynamicByteArray.java, line 287 > > > > > > Presumably totalLenght should be totalLength? Thanks for catching this.

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-23 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10712/#review19568 --- I didn't get a chance to go through the whole thing -- here are just

Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

2013-04-23 Thread Scott Preece
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10712/#review19581 --- Incomplete review - I had only a few minutes to look at it this morn