Re: HMS dependency on fb303.FacebookService

2017-12-01 Thread Alan Gates
Works for me. Alan. Sent from my iPhone > On Nov 28, 2017, at 10:55, Alexander Kolbasov wrote: > > Thanks for the reply Alan! > > The major problem with fb303 is that it is always a pain to deal with it > when you need to generate thrift code for other purposes. For backwards > compatibilit

Re: HMS dependency on fb303.FacebookService

2017-11-28 Thread Alexander Kolbasov
Thanks for the reply Alan! The major problem with fb303 is that it is always a pain to deal with it when you need to generate thrift code for other purposes. For backwards compatibility we may provide some simple implementation ourselves - does this sound reasonable? Alex On Tue, Nov 28, 2017 at

Re: HMS dependency on fb303.FacebookService

2017-11-28 Thread Alan Gates
Removing this break our backwards compatibility. This interface provides public methods like getName. Hive may not be using them but we have no idea if others are in the wild. Given that including this has little or no cost to us AFAIK, why remove it? Alan.​ On Mon, Nov 27, 2017 at 5:21 PM, Al