Re: [DISCUSS] SonarCloud integration for Apache Hive

Thanx Alessandro and Stamatis for driving this. If it is just highlighting the issues induced by the code changes in the current PR and not from the whole master or from all the files touched, It does make sense to integrate it, As Sonar is good with a lot of false alarms(personal experience), I to

Re: [DISCUSS] SonarCloud integration for Apache Hive

That's great news! From the initial message, I got the impression that the Sonar label in the PR will report all problems currently in master (and not only the new ones). I agree, it is better not to enforce quality gates directly but leave some time for the rest of us to get familiar with the too

Re: [DISCUSS] SonarCloud integration for Apache Hive

Hi Stamatis, glad to hear you find Sonar helpful, thanks for providing your feedback. The master branch analysis already provides what I think you are looking for, you have: - all code analysis (to see the full status of the code): https://sonarcloud.io/summary/overall?id=apache_hive - n

Re: [DISCUSS] SonarCloud integration for Apache Hive

Hi Alessandro, Sonar integration will definitely help in improving cope quality and preventing bugs so many thanks for pushing this forward. I went over the PR and it is in good shape. I plan to merge it in the following days unless someone objects. We can tackle further improvements in follow up

Re: [DISCUSS] SonarCloud integration for Apache Hive

Errata corrige: the right PR link is the following https://github.com/apache/hive/pull/3254 Best regards, Alessandro On Mon, 8 Aug 2022 at 10:04, Alessandro Solimando < alessandro.solima...@gmail.com> wrote: > Hi community, > in the context of HIVE-26196 >