Re: MiniHS2 and postgresql jars

2023-08-23 Thread Zoltán Rátkai
Hi, if I understand correctly the descriptions this would be no problem for the followings ? - Postgres - MSSQL - Derby "MariaDB, MySQL, and Oracle licenses are not compatible with Apache License 2 " I created a ticket to solve this issue: https://issues.apache.org/jira/browse/HIVE-27642 If we

Re: MiniHS2 and postgresql jars

2023-08-23 Thread Stamatis Zampetakis
Hello, For those interested about the full background behind the changes that partially broke StartMiniHS2Cluster please have a look at [1, 2, 3]. If something is not clear or we need to revisit those decisions I am happy to discuss further. Summarizing in one sentence, the bin.tar.gz and src.tag

Re: MiniHS2 and postgresql jars

2023-08-23 Thread Zsolt Miskolczi
As I understand, they have been removed due to licensing issues. Before we re-add the jar or add a possibility to include jars into the classpath, I want to understand the reason. What was the exact licensing issue? Do we have to make sure that we don't provide those jars in production? Or is it n

Re: MiniHS2 and postgresql jars

2023-08-22 Thread Stamatis Zampetakis
I am not against restoring itest.jdbc.jars property but for this case I prefer the explicit declaration of the dependency. Adding an optional or test scope dependency is much simpler and works out of the box. We don't need to download jars manually and we don't need to remember how the system prop

Re: MiniHS2 and postgresql jars

2023-08-22 Thread László Bodor
Yeah, I think we should simply re-add the possibility to add jars to classpath, call it "itest.jdbc.jars" to preserve the old behavior and parameter name. Denys Kuzmenko ezt írta (időpont: 2023. aug. 22., K, 12:43): > Instead of adding the dependencies, can't we add the possibility to > include

Re: MiniHS2 and postgresql jars

2023-08-22 Thread Denys Kuzmenko
Instead of adding the dependencies, can't we add the possibility to include jdbc jars in the classpath? something like this: org.apache.maven.plugins maven-failsafe-plugin integration-test verify ${itest.jdbc.jars}

Re: MiniHS2 and postgresql jars

2023-08-22 Thread Stamatis Zampetakis
If people are using it then it makes sense to keep it functional. Feel free to open a PR and add the missing dependency(ies) in the appropriate place; just ensure that they are not widely propagated if not necessary. Best, Stamatis On Mon, Aug 21, 2023 at 12:04 PM Zoltán Rátkai wrote: > > Hi Te

Re: MiniHS2 and postgresql jars

2023-08-21 Thread Zoltán Rátkai
Hi Team, I agree with Laszlo Bodor, it is a good tool to develop Hive. It worked properly before this PR. My question is how do you provide the missing database jar (e.g. Postgres driver) for StartMiniHS2Cluster, which is run by maven? If it requires to modify the pom file after this change, then

Re: MiniHS2 and postgresql jars

2023-08-21 Thread László Bodor
Hey! I tend to return to StartMiniHS2Cluster from time to time. It's very good for the "change code - compile - run - debug - repeat" way of doing things. >From this point of view, docker image is not an alternative to that. Also, StartMiniHS2Cluster just works, always, moreover, it uses the same

Re: MiniHS2 and postgresql jars

2023-08-18 Thread Stamatis Zampetakis
Hey Zsolt, I would divide this discussion into three topics: 1. What are the benefits of using the StartMiniHS2Cluster? 2. What other alternatives are there for testing HS2 with different metastore DBMS? 3. How can we make StartMiniHS2Cluster work as before? Regarding the point 1, I don't have a

MiniHS2 and postgresql jars

2023-08-15 Thread Zsolt Miskolczi
Hey there!Do you know how it is possible to use minihs2 with embedded metastore service but postgresql as the metastore database? Since I'm pretty sure it broke with that change https://github.com/apache/hive/pull/4317, handling drivers is changed: We don't bundle postgresql drivers with the hive