Re: [discuss] jdk8 support

2016-06-05 Thread Gopal Vijayaraghavan
+1 from me, it's been more than a year since JDK7 EOL. This needs a separate voting thread away from [discuss]. Cheers, Gopal On 6/4/16, 11:14 AM, "Lars Francke" wrote: >+1 for option 3 to drop Java 7 and start using Java8 features in code as >well > >On Fri, Jun 3, 2016 at 9:38 PM, Reuben Kuh

Re: [discuss] jdk8 support

2016-06-04 Thread Lars Francke
+1 for option 3 to drop Java 7 and start using Java8 features in code as well On Fri, Jun 3, 2016 at 9:38 PM, Reuben Kuhnert wrote: > +1 Drop Java7 support, start using JDK8 features. > > On Fri, Jun 3, 2016 at 12:39 PM, Prasanth Jayachandran < > pjayachand...@hortonworks.com> wrote: > > > +1 fo

Re: [discuss] jdk8 support

2016-06-03 Thread Reuben Kuhnert
+1 Drop Java7 support, start using JDK8 features. On Fri, Jun 3, 2016 at 12:39 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > +1 for using jdk8 as minimum required version. > > Thanks > Prasanth > > > > > On Fri, Jun 3, 2016 at 10:21 AM -0700, "Siddharth Seth"

Re: [discuss] jdk8 support

2016-06-03 Thread Prasanth Jayachandran
+1 for using jdk8 as minimum required version. Thanks Prasanth On Fri, Jun 3, 2016 at 10:21 AM -0700, "Siddharth Seth" mailto:ss...@apache.org>> wrote: +1. Drop Java7 support, and start using JDK8 features. On Fri, Jun 3, 2016 at 8:13 AM, Ashutosh Chauhan wrote: > What I meant was that we

Re: [discuss] jdk8 support

2016-06-03 Thread Siddharth Seth
+1. Drop Java7 support, and start using JDK8 features. On Fri, Jun 3, 2016 at 8:13 AM, Ashutosh Chauhan wrote: > What I meant was that we start compiling using jdk8 as well. That will > allow devs to use jdk8 only features (lambda functions etc.) > > On Fri, Jun 3, 2016 at 8:10 AM, Sergio Pena

Re: [discuss] jdk8 support

2016-06-03 Thread Ashutosh Chauhan
What I meant was that we start compiling using jdk8 as well. That will allow devs to use jdk8 only features (lambda functions etc.) On Fri, Jun 3, 2016 at 8:10 AM, Sergio Pena wrote: > Hey Ashutosh, > > I switched to JDK8 in master last weekend. Jenkins has been running all > tests in Java8 succ

Re: [discuss] jdk8 support

2016-06-03 Thread Sergio Pena
Hey Ashutosh, I switched to JDK8 in master last weekend. Jenkins has been running all tests in Java8 successfully for a week now. There are still a few tests we need to fix, but so far is looking good. Sergio On Fri, Jun 3, 2016 at 12:02 AM, Ashutosh Chauhan wrote: > Now that branch-2.1 has be

Re: [discuss] jdk8 support

2016-06-02 Thread Ashutosh Chauhan
Now that branch-2.1 has been cut, I think its an opportune time to drop support of jdk7 altogether in master. That is we compile using jdk8 as well. What do others think? Ashutosh On Fri, May 27, 2016 at 7:41 PM, Sergio Pena wrote: > I did the change to JDK8 on Ptest now. > > Please let me tkno

Re: [discuss] jdk8 support

2016-05-27 Thread Sergio Pena
I did the change to JDK8 on Ptest now. Please let me tknow if there are issues with Java8. - Sergio On Fri, May 27, 2016 at 2:45 PM, Sergio Pena wrote: > Thanks Mohit. > > I will plan to do the JDK8 change on Jenkins today EOD and monitor any > issues through the weekend. > > - Sergio > > > On

Re: [discuss] jdk8 support

2016-05-27 Thread Sergio Pena
Thanks Mohit. I will plan to do the JDK8 change on Jenkins today EOD and monitor any issues through the weekend. - Sergio On Fri, May 27, 2016 at 2:58 AM, Mohit Sabharwal wrote: > Update on moving Hive2 tests to JDK8: I've addressed almost all test > failures in HIVE-13547 on java8 branch. Th

Re: [discuss] jdk8 support

2016-05-27 Thread Mohit Sabharwal
Update on moving Hive2 tests to JDK8: I've addressed almost all test failures in HIVE-13547 on java8 branch. There is one remaining open item (HIVE-13834) which is currently assigned. Given current state of flaky test runs, there might be few more. I will work with Sergio to merge the test fixes t

Re: [discuss] jdk8 support

2016-04-19 Thread Mohit Sabharwal
Created HIVE-13547 to track switching 2x tests to JDK8. On Wed, Apr 13, 2016 at 10:02 AM, Sergio Pena wrote: > I agree with such change as JDK7 is not longer supported. > > Changes on Jenkins and Hive PTest shouldn't be hard. We just need to > replace the path from java7 to java8. But I think we

Re: [discuss] jdk8 support

2016-04-13 Thread Sergio Pena
I agree with such change as JDK7 is not longer supported. Changes on Jenkins and Hive PTest shouldn't be hard. We just need to replace the path from java7 to java8. But I think we should fix all JDK8 issues or most of them before doing the change or we will end up having a lot of failures on all J

Re: [discuss] jdk8 support

2016-04-11 Thread Siddharth Seth
Option 3 sounds good. I'd ideally like to make JDK8 the minimum requirement soon as well. On Mon, Apr 11, 2016 at 4:59 PM, Szehon Ho wrote: > Sounds like a good plan, +1 > > On Mon, Apr 11, 2016 at 4:31 PM, Mohit Sabharwal > wrote: > > > Thanks, Ashutosh. Makes sense to keep the source and targ

Re: [discuss] jdk8 support

2016-04-11 Thread Szehon Ho
Sounds like a good plan, +1 On Mon, Apr 11, 2016 at 4:31 PM, Mohit Sabharwal wrote: > Thanks, Ashutosh. Makes sense to keep the source and target as 1.7 since > we're not using any JDK8 specific features yet. So, option (3) essentially > just means using JDK8 exclusively to build & test Hive2. >

Re: [discuss] jdk8 support

2016-04-11 Thread Mohit Sabharwal
Thanks, Ashutosh. Makes sense to keep the source and target as 1.7 since we're not using any JDK8 specific features yet. So, option (3) essentially just means using JDK8 exclusively to build & test Hive2. On Sat, Apr 9, 2016 at 12:23 PM, Ashutosh Chauhan wrote: > Hi Mohit, > > I also think optio

Re: [discuss] jdk8 support

2016-04-09 Thread Ashutosh Chauhan
Hi Mohit, I also think option 3 makes sense. We should strive to keep test matrix small so that we can do fast QA runs for dev patches. We can just use jdk7 to build & test Hive1 and jdk8 to build & test Hive2. However, I am not sure of explicitly dropping support altogether for jdk7 on Hive2. We

[discuss] jdk8 support

2016-04-08 Thread Mohit Sabharwal
Hi folks, Oracle EOL'ed (ended public updates) for Java 7 in April 2015. In order to support Java 8, we fixed quite a bunch of tests in HIVE-8607 (*) early last year. However, since our pre-commit tests run on JDK7 only, any JDK8 test failures are getting ignored. As a result, the count has crept