Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Ashutosh Chauhan
No patch doesn't do that in reverse. You may read my comments on jira. I think we should leave this patch in and do a follow-up jira for the change I suggested in previous email (and in jira comments). On Tue, Jun 14, 2016 at 4:20 PM, Sergey Shelukhin wrote: > Doesn’t the patch in question do th

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Sergey Shelukhin
Doesn’t the patch in question do the reverse? I think we can have a follow-up JIRA if it’s not already done in all circumstances, without the patch. On 16/6/14, 16:13, "Ashutosh Chauhan" wrote: >What about my suggestions to treat non-integral constant literals as >BigDecimal instead of Double? I

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Ashutosh Chauhan
What about my suggestions to treat non-integral constant literals as BigDecimal instead of Double? I checked on other products and thats what MySQL, Oracle & SQL server is doing. Thanks, Ashutosh On Tue, Jun 14, 2016 at 4:07 PM, Alan Gates wrote: > I’m +1 on reverting it. Let’s not change arou

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Alan Gates
I’m +1 on reverting it. Let’s not change around functionality on our users and let’s stay as close as possible to the standard, both of which reverting this seems to do. Alan. > On Jun 10, 2016, at 16:07, Sergey Shelukhin wrote: > > There has recently been a change in behavior in Hive wrt do

Re: [discuss] decimals vs doubles in Hive

2016-06-14 Thread Sergey Shelukhin
I am overwhelmed by the response ;) If there are no objections I’m going to revert the patch also from master tomorrow. On 16/6/10, 16:07, "Sergey Shelukhin" wrote: >There has recently been a change in behavior in Hive wrt doubles and >decimals, HIVE-13380; where the literals were changed to be

[discuss] decimals vs doubles in Hive

2016-06-10 Thread Sergey Shelukhin
There has recently been a change in behavior in Hive wrt doubles and decimals, HIVE-13380; where the literals were changed to be double by default, resulting in some unexpected behavior when comparing decimal columns with arithmetic expressions on literals. Right now it has been reverted from 2.1,