Re: [Discuss] Patch submission and commit format

The one from git format-patch would have an header which looks like an email header - For example - >From 1a1c0d817da036025f1c3b953af7b52403c048ba Mon Sep 17 00:00:00 2001 From: Alan Gates Date: Wed, 1 Jul 2015 15:47:03 -0700 Subject: [PATCH] HIVE-11061 Table renames not propagated to partition t

Re: [Discuss] Patch submission and commit format

When we are committing another's patch is there an easy way to tell whether they properly generated via git format-patch or another method? Alan. Thejas Nair July 14, 2015 at 10:56 In case the patch is generated using a simple git-diff or another method that is n

Re: [Discuss] Patch submission and commit format

In case the patch is generated using a simple git-diff or another method that is not of same format as git format-patch , you can use the following command to commit with attribution - git commit -a -m ' … ' --author="Name of the author" I verified that it shows the attribution after the commit -

Re: [Discuss] Patch submission and commit format

@Lefty : Nothing happens if someone doesn't follow convention. I don't know if this can be enforced automatically. @Sergey : I don't know enough git to answer that. If someone can make this enforceable that will be good, but its not required. Others, Seems like there is an agreement here. I will u

Re: [Discuss] Patch submission and commit format

I like this idea of the commit format. Maybe we could use some git hooks to enforce a commit to be in a specific format and to have a contributor too. I found this article about git hooks we can use on the server-side to enforce this: https://www.atlassian.com/git/tutorials/git-hooks https://git-

Re: [Discuss] Patch submission and commit format

The existing approach appears to be “HIVE-X : fix the bugs (John Doe, reviewed by John Smith)” or something like that in the commit message. I think the new approach is better… +1 Can you create a detailed instruction? Is it enforceable in git? On 15/7/10, 11:08, "Ashutosh Chauhan" wrote: >T

Re: [Discuss] Patch submission and commit format

What happens if someone doesn't follow the conventions? Can they be enforced automatically? -- Lefty On Fri, Jul 10, 2015 at 2:23 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > Great idea. Definitely we should attribute the contributions from the > author in a better way. +

Re: [Discuss] Patch submission and commit format

Great idea. Definitely we should attribute the contributions from the author in a better way. +1. We should update the docs on “How to Contribute?” to generate the patch using format-path. > On Jul 10, 2015, at 11:08 AM, Ashutosh Chauhan wrote: > > There was a problem of attributing contributi

[Discuss] Patch submission and commit format

There was a problem of attributing contributions correctly back when we were using svn, now that we are on git, that problem can be addressed. This email is an effort to solicit feedback for it. Problem: In svn, there is only a committer field, so when committer was committing someone else's patch