Thanks everyone for the valuable feedback!
I think we have consensus to drop contributor and reviewers name from the
commit message. As of now we can start applying the new style. I can also
try to find a place on the website to mention the new style.
Just to avoid any confusion, I am not suggest
IMO, It is enough to mention&thank the contributor & reviewers in the Github
page.
For the Jira page, it's sufficient to express gratitude to the author only.
There is no need to mention the reviewer. Because it can be rather troublesome
to look up the Jira account of the reviewer sometimes & a
+1
I also confirmed that we have followed the practice since at least
2015 before we moved to GitHub, so it is likely to have purposes other
than incentives. Also, no one, including me, has proven it could be a
strong incentive. I second the idea of improving the current real
process.
Regarding B
+1
BTW, Should we also ignore mentioning the contributors and reviewers in the
corresponding JIRA? And then directly just closed the JIRA?
-Butao
On 2025/04/08 16:22:33 Ayush Saxena wrote:
> I feel that for some folks—especially those new to the project—seeing
> their name in the commit message
I feel that for some folks—especially those new to the project—seeing
their name in the commit message might serve as a small motivation to
review more. The practice of including the author name I believe has
been around since the SVN days or the patch days, or even earlier,
when committers used to
+1 for the author part.
Regarding the reviewers' names, I have one thouht from a bit diffrent
angle. The number of reviewers is always the biggest bottleneck. If the
small praize motivates people and they try one more review, it is
meaningful. But I don't have any evidence about how many people fe
+1.
I don't see the value in that.
Attila Turoczy ezt írta (időpont: 2025.
ápr. 8., K, 16:32):
> +1.It's a thoughtful gesture for reviewers, but if it creates headaches
> for the dev's and adds unnecessary steps, I think we can live without it.
>
> -Attila
>
> On Tue, Apr 8, 2025 at 4:27 PM Sta
+1.It's a thoughtful gesture for reviewers, but if it creates headaches for
the dev's and adds unnecessary steps, I think we can live without it.
-Attila
On Tue, Apr 8, 2025 at 4:27 PM Stamatis Zampetakis
wrote:
> Hi all,
>
> How do you feel about dropping the contributor and reviewer names fro
Hi all,
How do you feel about dropping the contributor and reviewer names from
the commit summary?
Before:
HIVE-28884: Decouple source.q test from SRC dataset (Stamatis
Zampetakis reviewed by Soumyakanti Das, Zsolt Miskolczi, Shohei
Okumiya, Simhadri Govindappa)
After:
HIVE-28884: Decouple sour
