Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-16 Thread david seraf
/ Testing --- added code test and added QL test. Tests passed in CI, but other, unrelated tests failed. Thanks, david seraf

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-16 Thread david seraf
3612 ------- On Sept. 12, 2014, 9:51 p.m., david seraf wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25178/ > -

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-16 Thread david seraf
> > Also, both methods are new and private. I'm not sure if I undertand the > > complexity of the change. > > david seraf wrote: > I misunderstood. I'm fine with changing those 2 methods. I looked at this in more detail and the problem is that drop

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-15 Thread david seraf
y generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review53259 --- On Sept. 12, 2014, 9:51 p.m., david seraf wrote: > > --- > Thi

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
/drop_table_purge.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25178/diff/ Testing --- added code test and added QL test. Tests passed in CI, but other, unrelated tests failed. Thanks, david seraf

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
for the solution to be complete. We'll > > need a new `dropPartitions()` overload that takes an ifPurge flag. This > > method should forward to the new method. > > david seraf wrote: > I'm looking at it, but I think it may be a large enough change to justify

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52911 ------- On Sept. 12, 2014, 8:28 p.m., david seraf wrote: > > --- > This is an automatically generated e

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
. Tests passed in CI, but other, unrelated tests failed. Thanks, david seraf

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
/drop_table_purge.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25178/diff/ Testing --- added code test and added QL test. Tests passed in CI, but other, unrelated tests failed. Thanks, david seraf

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-09 Thread david seraf
PRE-CREATION Diff: https://reviews.apache.org/r/25178/diff/ Testing --- added code test and added QL test. Tests passed in CI, but other, unrelated tests failed. Thanks, david seraf

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-08 Thread david seraf
7;ll > > need a new `dropPartitions()` overload that takes an ifPurge flag. This > > method should forward to the new method. I'm looking at it, but I think it may be a large enough change to justify a separate ticket. - david --------

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-04 Thread david seraf
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52279 ------- On Sept. 2, 2014, 11:41 p.m., david seraf wrote: > >

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-02 Thread david seraf
://reviews.apache.org/r/25178/diff/ Testing --- added code test and added QL test. Tests passed in CI, but other, unrelated tests failed. Thanks, david seraf

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-02 Thread david seraf
/25178/diff/ Testing --- added code test and added QL test. Tests passed in CI, but other, unrelated tests failed. Thanks, david seraf

Re: Review Request 25178: Add DROP TABLE PURGE

2014-09-02 Thread david seraf
. Thanks, david seraf