Re: Review Request 60303: HIVE-16908: Update table and partition replication tests to not use 2nd HCat instance

2017-06-21 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60303/ --- (Updated June 22, 2017, 12:59 a.m.) Review request for hive, Carl Steinbach, An

Review Request 60303: HIVE-16908: Update table and partition replication tests to not use 2nd HCat instance

2017-06-21 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60303/ --- Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti. Bugs

Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-07 Thread Sunitha Beeram via Review Board
> On June 7, 2017, 8:45 p.m., Anthony Hsu wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 302 (original), 304 (patched) > > > > > > Do we need to close the PersistenceManager

Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-07 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59885/ --- Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti. Bugs

Review Request 59867: HIVE-16831: Add unit tests for NPE fixes in HIVE-12054

2017-06-06 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59867/ --- Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti. Bugs

Review Request 58227: Hive-16393: Fix visibility of CodahaleReporter interface

2017-04-05 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58227/ --- Review request for hive, Carl Steinbach and Ratandeep Ratti. Bugs: HIVE-16393

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-31 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 31, 2017, 9:16 p.m.) Review request for hive, Carl Steinbach and

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-23 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 23, 2017, 4:27 p.m.) Review request for hive, Carl Steinbach and

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 23, 2017, 12:45 a.m.) Review request for hive, Carl Steinbach an

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 21, 2017, 4:31 p.m., Ratandeep Ratti wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java > > Lines 74 (patched) > > > > > > What all exception types are th

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote: > > Thanks for the changes Sunitha. Few comments below. Thanks for reviewing! Appreciate it. > On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 21, 2017, 4:34 p.m., Ratandeep Ratti wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java > > Lines 83 (patched) > > > > > > Can some of the logic can be mo

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 21, 2017, 6:25 a.m., Carl Steinbach wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java > > Line 433 (original), 382 (patched) > > > > > > Please consider pushing

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 21, 2017, 4:05 p.m.) Review request for hive, Carl Steinbach and

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-20 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 20, 2017, 3:44 p.m.) Review request for hive, Carl Steinbach and

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-20 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 20, 2017, 3:40 p.m.) Review request for hive, Carl Steinbach and