Re: Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-08-09 Thread Shefali Vohra
e as index 0 in the array is still the best option? - Shefali ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6027/#review9924 --- On July 18, 2012, 12:56 a.m., Shefali Vohra wrote: > > -

[jira] [Commented] (HIVE-3216) DateDiff UDF overload with a unit parameter

2012-08-09 Thread Shefali Vohra (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432176#comment-13432176 ] Shefali Vohra commented on HIVE-3216: - Ashutosh, I have left some comments on

[jira] [Updated] (HIVE-3216) DateDiff UDF overload with a unit parameter

2012-07-17 Thread Shefali Vohra (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shefali Vohra updated HIVE-3216: Status: Patch Available (was: Open) > DateDiff UDF overload with a unit parame

[jira] [Updated] (HIVE-3216) DateDiff UDF overload with a unit parameter

2012-07-17 Thread Shefali Vohra (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shefali Vohra updated HIVE-3216: Attachment: HIVE-3216.1.patch.txt Review Link: https://reviews.apache.org/r/6027

Re: Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-07-17 Thread Shefali Vohra
q.out 1362724 Diff: https://reviews.apache.org/r/6027/diff/ Testing (updated) --- positive and negative test cases included Thanks, Shefali Vohra

Review Request: This function overloads the current DateDiff(expr1, expr2) by adding another parameter to specify the units.

2012-07-17 Thread Shefali Vohra
he.org/r/6027/diff/ Testing --- yes Thanks, Shefali Vohra

[jira] [Created] (HIVE-3216) DateDiff UDF overload with a unit parameter

2012-06-29 Thread Shefali Vohra (JIRA)
Shefali Vohra created HIVE-3216: --- Summary: DateDiff UDF overload with a unit parameter Key: HIVE-3216 URL: https://issues.apache.org/jira/browse/HIVE-3216 Project: Hive Issue Type: Improvement

RE: Hive Unit Tests: Read-Only Table

2012-06-12 Thread Shefali Vohra
gt;You cannot change tables which are created by QTestUtil (like src). > > >On 6/12/12 12:34 PM, "Shefali Vohra" wrote: > >>Fair enough. So (just to make sure) if I need to create a table to run >>a test, I should do so within the .q file itself? >>

RE: Hive Unit Tests: Read-Only Table

2012-06-12 Thread Shefali Vohra
any code. On Tue, Jun 12, 2012 at 3:24 PM, Shefali Vohra wrote: > Sorry I think my original message was a bit ambiguous and I think my error is > a little different than what it may have implied. > From what I understand, the *.q files contain Hive queries such as select * > from tabl

RE: Hive Unit Tests: Read-Only Table

2012-06-12 Thread Shefali Vohra
ve/whatever.q Or give this a go (its a unit testing tool I wrote): https://github.com/edwardcapriolo/hive_test On Tue, Jun 12, 2012 at 1:47 PM, Shefali Vohra wrote: > Hi! > I'm trying to add unit tests to a UDF I developed, and used the commands > runCreateTableCmd and runLoadCmd to

Hive Unit Tests: Read-Only Table

2012-06-12 Thread Shefali Vohra
Hi! I'm trying to add unit tests to a UDF I developed, and used the commands runCreateTableCmd and runLoadCmd to create and load the table. I'm fairly certain it is loading from the correct filepath. When I try to run it though, I get the error "Cannot overwrite read-only table." Does anybody h