Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-19 Thread PRASHANT GOLASH via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60950/ --- (Updated July 20, 2017, 12:39 a.m.) Review request for hive. Changes ---

Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-19 Thread PRASHANT GOLASH via Review Board
> On July 19, 2017, 10:12 p.m., Chao Sun wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 283 (patched) > > > > > > These do not seem unnecessary. Maybe replace with: > >

Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-19 Thread PRASHANT GOLASH via Review Board
> On July 19, 2017, 11:46 a.m., Mohit Sabharwal wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > > Lines 471 (patched) > > > > > > Don't think you need this

Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-19 Thread PRASHANT GOLASH via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60950/ --- (Updated July 19, 2017, 8:49 p.m.) Review request for hive. Changes ---

Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-19 Thread PRASHANT GOLASH via Review Board
> On July 19, 2017, 3:21 a.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 283 (patched) > > > > > > is this really needed ? see comment below. For sam

Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-19 Thread PRASHANT GOLASH via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60950/ --- (Updated July 19, 2017, 7:40 a.m.) Review request for hive. Changes ---

Re: Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-18 Thread PRASHANT GOLASH via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60950/ --- (Updated July 18, 2017, 10:58 p.m.) Review request for hive. Changes ---

Review Request 60950: [HIVE-17117] - Meta listeners are not notified of meta-conf cleanup.

2017-07-18 Thread PRASHANT GOLASH via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60950/ --- Review request for hive. Repository: hive-git Description --- Added the