I feel that for some folks—especially those new to the project—seeing
their name in the commit message might serve as a small motivation to
review more. The practice of including the author name I believe has
been around since the SVN days or the patch days, or even earlier,
when committers used to
+1 for the author part.
Regarding the reviewers' names, I have one thouht from a bit diffrent
angle. The number of reviewers is always the biggest bottleneck. If the
small praize motivates people and they try one more review, it is
meaningful. But I don't have any evidence about how many people fe
+1.
I don't see the value in that.
Attila Turoczy ezt írta (időpont: 2025.
ápr. 8., K, 16:32):
> +1.It's a thoughtful gesture for reviewers, but if it creates headaches
> for the dev's and adds unnecessary steps, I think we can live without it.
>
> -Attila
>
> On Tue, Apr 8, 2025 at 4:27 PM Sta
+1.It's a thoughtful gesture for reviewers, but if it creates headaches for
the dev's and adds unnecessary steps, I think we can live without it.
-Attila
On Tue, Apr 8, 2025 at 4:27 PM Stamatis Zampetakis
wrote:
> Hi all,
>
> How do you feel about dropping the contributor and reviewer names fro
Hi all,
How do you feel about dropping the contributor and reviewer names from
the commit summary?
Before:
HIVE-28884: Decouple source.q test from SRC dataset (Stamatis
Zampetakis reviewed by Soumyakanti Das, Zsolt Miskolczi, Shohei
Okumiya, Simhadri Govindappa)
After:
HIVE-28884: Decouple sour
The upgrade to JDK 17 is a significant change that introduces compatibility and
adaptation requirements for both Apache Tez and Apache Hive. Relevant work is
currently in progress—thanks to all community contributors who have already
been involved in adaptation and fixes. We encourage everyone t
I'm definitely +1 on this proposal.
Apache Hive has deeply integrated the Iceberg table format for several years
now. Switching the default table format to Iceberg would send a strong and
positive signal to the community: that Iceberg has become a first-class citizen
in the Hive engine, and it'
The PR has two reviews but lacks a binding +1. Can a commiter take a look:
https://github.com/apache/hive/pull/5750
Best,
Stamatis
