Exactly, I was mostly referring to adding/removing empty comments and
javadocs and minor changes in them.
On Fri, Jul 26, 2024, 7:04 PM Alessandro Solimando <
alessandro.solima...@gmail.com> wrote:
> I agree that adding an insightful comment or javadoc might significantly
> improve the readabilit
I agree that adding an insightful comment or javadoc might significantly
improve the readability and maintainability of the code and that is an
added value.
In my understanding, Stamatis is talking about minor fixes like typos or
similar, which are probably better addressed within PRs already touc
I agree with most of that.
But comments and javadoc? I guess it depends on the situation, but any
clarification of code would seem to me to be a good thing.
If someone took the time to document something, they might have been
cursing for hours trying to figure out what was going on with that sp
+1
On Fri, 26 Jul 2024 at 11:21, Stamatis Zampetakis
wrote:
> Hi all,
>
> In some cases we receive PRs/JIRAs with minor non-code improvements:
> * fix small typos in very specific places
> * empty lines/javadoc/comments
> * minor rewording
>
> Personally, I feel that such changes have more negat
Hi all,
Master and all recent PRs are failing with OOM [1] and the latter
seems persistent. Please stop merging more stuff till the problem is
resolved.
Best,
Stamatis
[1] https://issues.apache.org/jira/browse/HIVE-28402
Hi all,
In some cases we receive PRs/JIRAs with minor non-code improvements:
* fix small typos in very specific places
* empty lines/javadoc/comments
* minor rewording
Personally, I feel that such changes have more negatives than
positives for the Hive project and I am listing a few below:
* Con
