Re: Force coding style in hive precommit

2024-01-07 Thread Kirti Ruge
+1 As it would improve maintainability and code reviews. Sometimes small indentation/styling issues would kill review cycle time and we can easily avoid it before requesting review. Enforcing more rules around it definitely boost guaranteeing quality. We can integrate it with git hooks. If we ar

Re: Force coding style in hive precommit

2024-01-07 Thread Akshat m
+1, We do have a documentation round it as well: https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions so it makes sense to enforce it as well. Right now we have a small section around this in documentation, We can also expand this to a new page and add

Re: How to use `engine` introduced by HIVE-22046

2024-01-07 Thread Butao Zhang
Hi, dev Bump this thread! I just filed a ticket to track&fix this incompatibility issues about hms column stats thrift api. I think we can fix this at its root in HMS side and then any other third components will not suffer from this issue. https://issues.apache.org/jira/browse/HIVE-27984 Tha