Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64688/ --- (Updated Feb. 10, 2018, 5:48 a.m.) Review request for hive, Ashutosh Chauhan an

Closing of JIRAs

2018-02-09 Thread Madhudeep petwal
Hi all, I have noticed this that a lot of JIRAs are unnecessary, either they are wrongly reproduced or duplicates. One such example is this JIRA which I came across. Can someone please tell me the procedure to close the JIRAs ? As we have this la

Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Deepak Jaiswal
> On Feb. 10, 2018, 2:44 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVertex.java > > Line 548 (original), 579 (patched) > > > > > > If a bucket file is missing in the lis

Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64688/#review197216 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVer

Review Request 65596: HIVE-18678 fix exim for MM tables and reinstante the test

2018-02-09 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65596/ --- Review request for hive and Eugene Koifman. Repository: hive-git Description

[jira] [Created] (HIVE-18678) fix exim for MM tables and reinstante the test

2018-02-09 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18678: --- Summary: fix exim for MM tables and reinstante the test Key: HIVE-18678 URL: https://issues.apache.org/jira/browse/HIVE-18678 Project: Hive Issue Type:

Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64688/ --- (Updated Feb. 10, 2018, 12:41 a.m.) Review request for hive, Ashutosh Chauhan a

Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64688/ --- (Updated Feb. 10, 2018, 12:05 a.m.) Review request for hive, Ashutosh Chauhan a

[jira] [Created] (HIVE-18677) SparkClientImpl usage of SessionState.LogHelper doesn't respect isSilent value

2018-02-09 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-18677: --- Summary: SparkClientImpl usage of SessionState.LogHelper doesn't respect isSilent value Key: HIVE-18677 URL: https://issues.apache.org/jira/browse/HIVE-18677 Project: H

[jira] [Created] (HIVE-18676) Usability: Better warnings for Unicode single quotes

2018-02-09 Thread Gopal V (JIRA)
Gopal V created HIVE-18676: -- Summary: Usability: Better warnings for Unicode single quotes Key: HIVE-18676 URL: https://issues.apache.org/jira/browse/HIVE-18676 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18675) make HIVE_LOCKS.HL_TXNID NOT NULL

2018-02-09 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18675: - Summary: make HIVE_LOCKS.HL_TXNID NOT NULL Key: HIVE-18675 URL: https://issues.apache.org/jira/browse/HIVE-18675 Project: Hive Issue Type: Bug Co

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Feb. 9, 2018, 9:46 p.m.) Review request for hive and Eugene Koifman.

[jira] [Created] (HIVE-18674) update Hive to use ORC 1.4.3

2018-02-09 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18674: --- Summary: update Hive to use ORC 1.4.3 Key: HIVE-18674 URL: https://issues.apache.org/jira/browse/HIVE-18674 Project: Hive Issue Type: Bug R

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same compBuilder.setIsAci

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 7, 2018, 11:24 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same compBuilder.setIsAc

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > stupid RB won't let me edit my own commen

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 3, 2018, 1:26 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > This seems to change the logic. isAcidTab

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Sergey Shelukhin
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same compBuilder.setIsAci

[jira] [Created] (HIVE-18673) ErrorMsg.SPARK_JOB_MONITOR_TIMEOUT isn't formatted correctly

2018-02-09 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-18673: --- Summary: ErrorMsg.SPARK_JOB_MONITOR_TIMEOUT isn't formatted correctly Key: HIVE-18673 URL: https://issues.apache.org/jira/browse/HIVE-18673 Project: Hive Issu

[jira] [Created] (HIVE-18672) Printed state in RemoteSparkJobMonitor is ambiguous

2018-02-09 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-18672: --- Summary: Printed state in RemoteSparkJobMonitor is ambiguous Key: HIVE-18672 URL: https://issues.apache.org/jira/browse/HIVE-18672 Project: Hive Issue Type: Su

Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64688/#review197177 --- ql/src/test/results/clientnegative/bucket_mapjoin_mismatch1.q.out

Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Jason Dere
> On Feb. 9, 2018, 5:59 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > > Lines 582 (patched) > > > > > > Thought different number of buckets was supposed to work

[jira] [Created] (HIVE-18671) lock not released after Hive on Spark query was cancelled

2018-02-09 Thread Yongzhi Chen (JIRA)
Yongzhi Chen created HIVE-18671: --- Summary: lock not released after Hive on Spark query was cancelled Key: HIVE-18671 URL: https://issues.apache.org/jira/browse/HIVE-18671 Project: Hive Issue Ty

Re: Review Request 64688: HIVE-18218

2018-02-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64688/#review197145 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoi

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > stupid RB won't let me edit my own comme

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 2, 2018, 5:26 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > > > > > This seems to change the logic. isAcidTab

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-09 Thread Eugene Koifman
> On Feb. 7, 2018, 11:24 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java > > Line 429 (original), 429 (patched) > > > > > > Below, you left the same compBuilder.setIsAc

[jira] [Created] (HIVE-18670) Prevent DROP DATABASE If Data Exists in HDFS

2018-02-09 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HIVE-18670: -- Summary: Prevent DROP DATABASE If Data Exists in HDFS Key: HIVE-18670 URL: https://issues.apache.org/jira/browse/HIVE-18670 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-18669) Deprecate hive.mapred.mode For New Name

2018-02-09 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HIVE-18669: -- Summary: Deprecate hive.mapred.mode For New Name Key: HIVE-18669 URL: https://issues.apache.org/jira/browse/HIVE-18669 Project: Hive Issue Type: Improvement

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

2018-02-09 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 9, 2018, 8:07 p.m.) Review request for hive. Repository: hive-g

[jira] [Created] (HIVE-18668) Really shade guava in ql

2018-02-09 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18668: --- Summary: Really shade guava in ql Key: HIVE-18668 URL: https://issues.apache.org/jira/browse/HIVE-18668 Project: Hive Issue Type: Bug Repor