Re: Review Request 65172: HIVE-18450

2018-01-19 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65172/ --- (Updated Jan. 20, 2018, 2:02 a.m.) Review request for hive and Ashutosh Chauhan

[jira] [Created] (HIVE-18503) MM/ACID tables: make tests that will never be compatible with acid use non-txn tables explicitly

2018-01-19 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18503: --- Summary: MM/ACID tables: make tests that will never be compatible with acid use non-txn tables explicitly Key: HIVE-18503 URL: https://issues.apache.org/jira/browse/HIVE-185

Re: Review Request 65172: HIVE-18450

2018-01-19 Thread Jesús Camacho Rodríguez
> On Jan. 20, 2018, 1:01 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Lines 2701 (patched) > > > > > > Whats PTF node? Is it over clause? If so, can we add so

Re: Review Request 65172: HIVE-18450

2018-01-19 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65172/#review195863 --- ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java Lines

Review Request 65250: HIVE-18387

2018-01-19 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65250/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-18387 https://issu

[jira] [Created] (HIVE-18502) base_-9223372036854775808 is confusing

2018-01-19 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18502: - Summary: base_-9223372036854775808 is confusing Key: HIVE-18502 URL: https://issues.apache.org/jira/browse/HIVE-18502 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-18501) Typo in beeline code

2018-01-19 Thread Naveen Gangam (JIRA)
Naveen Gangam created HIVE-18501: Summary: Typo in beeline code Key: HIVE-18501 URL: https://issues.apache.org/jira/browse/HIVE-18501 Project: Hive Issue Type: Bug Components: Beeli

Re: Switched PreCommit-Admin over to Apache Yetus

2018-01-19 Thread Allen Wittenauer
> On Jan 19, 2018, at 11:15 AM, Eric Wohlstadter wrote: > Is it possible for you to check whether Tez has been affected? > https://issues.apache.org/jira/projects/TEZ/ There weren't any (that I saw at least) in the queue when I fired off of the new build, but Tez does use precommit-admi

[jira] [Created] (HIVE-18500) annoying exceptions from LLAP Jmx view in the logs

2018-01-19 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18500: --- Summary: annoying exceptions from LLAP Jmx view in the logs Key: HIVE-18500 URL: https://issues.apache.org/jira/browse/HIVE-18500 Project: Hive Issue T

Re: Switched PreCommit-Admin over to Apache Yetus

2018-01-19 Thread Eric Wohlstadter
Hi Allen, Thanks for providing the update. Is it possible for you to check whether Tez has been affected? https://issues.apache.org/jira/projects/TEZ/ For the last few days my patches aren't triggering any submission hook. Here is an example: https://issues.apache.org/jira/browse/TEZ-3888 In ex

[jira] [Created] (HIVE-18499) Amend point lookup tests to check for data

2018-01-19 Thread Janaki Lahorani (JIRA)
Janaki Lahorani created HIVE-18499: -- Summary: Amend point lookup tests to check for data Key: HIVE-18499 URL: https://issues.apache.org/jira/browse/HIVE-18499 Project: Hive Issue Type: Bug

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-19 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195825 --- Looks good! I added small issues to fix, similarly with the dropPa

Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-19 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18496 https:

Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-19 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18498 https:

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-19 Thread Adam Szita via Review Board
> On Jan. 19, 2018, 11:41 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 122 (patched) > > > > > > nit: Why static? I like m

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-19 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 19, 2018, 2:29 p.m.) Review request for hive, Marta Kuczora and P

[jira] [Created] (HIVE-18498) Create tests to cover get and list index methods

2018-01-19 Thread Marta Kuczora (JIRA)
Marta Kuczora created HIVE-18498: Summary: Create tests to cover get and list index methods Key: HIVE-18498 URL: https://issues.apache.org/jira/browse/HIVE-18498 Project: Hive Issue Type: Sub

Review Request 65237: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-19 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65237/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18496 https:

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-19 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195811 --- Thanks Marta for the patch. Some questions below. Also I think it

[jira] [Created] (HIVE-18497) JDBC connection parameter to control socket read timeout

2018-01-19 Thread Amruth S (JIRA)
Amruth S created HIVE-18497: --- Summary: JDBC connection parameter to control socket read timeout Key: HIVE-18497 URL: https://issues.apache.org/jira/browse/HIVE-18497 Project: Hive Issue Type: Impro

[jira] [Created] (HIVE-18496) Create tests to cover add/alter/drop index methods

2018-01-19 Thread Marta Kuczora (JIRA)
Marta Kuczora created HIVE-18496: Summary: Create tests to cover add/alter/drop index methods Key: HIVE-18496 URL: https://issues.apache.org/jira/browse/HIVE-18496 Project: Hive Issue Type: S

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-19 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review195796 --- Overall looks good, I just have small observations. One more nitp

[jira] [Created] (HIVE-18495) JUnit rule to enable Driver level testing

2018-01-19 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18495: --- Summary: JUnit rule to enable Driver level testing Key: HIVE-18495 URL: https://issues.apache.org/jira/browse/HIVE-18495 Project: Hive Issue Type: Sub-

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-19 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review195809 --- Thanks Marta for the patch. Just one question. Peter standalone

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-19 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195795 --- Thanks for the patch Adam. Questions, and some minor comments. Th

[jira] [Created] (HIVE-18494) Regression: from HIVE-18069, the metastore directsql is getting disabled

2018-01-19 Thread Gopal V (JIRA)
Gopal V created HIVE-18494: -- Summary: Regression: from HIVE-18069, the metastore directsql is getting disabled Key: HIVE-18494 URL: https://issues.apache.org/jira/browse/HIVE-18494 Project: Hive Is