[GitHub] [httpcomponents-client] dependabot[bot] opened a new pull request, #410: Bump mockito-core from 4.8.1 to 5.1.1

2023-02-03 Thread via GitHub
dependabot[bot] opened a new pull request, #410: URL: https://github.com/apache/httpcomponents-client/pull/410 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.1 to 5.1.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's relea

[GitHub] [httpcomponents-client] dependabot[bot] closed pull request #408: Bump mockito-core from 4.8.1 to 5.0.0

2023-02-03 Thread via GitHub
dependabot[bot] closed pull request #408: Bump mockito-core from 4.8.1 to 5.0.0 URL: https://github.com/apache/httpcomponents-client/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [httpcomponents-client] dependabot[bot] commented on pull request #408: Bump mockito-core from 4.8.1 to 5.0.0

2023-02-03 Thread via GitHub
dependabot[bot] commented on PR #408: URL: https://github.com/apache/httpcomponents-client/pull/408#issuecomment-1415842335 Superseded by #410. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [httpcomponents-core] dependabot[bot] opened a new pull request, #384: Bump mockito-core from 4.11.0 to 5.1.1

2023-02-03 Thread via GitHub
dependabot[bot] opened a new pull request, #384: URL: https://github.com/apache/httpcomponents-core/pull/384 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.1.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's relea

[GitHub] [httpcomponents-core] dependabot[bot] commented on pull request #382: Bump mockito-core from 4.11.0 to 5.0.0

2023-02-03 Thread via GitHub
dependabot[bot] commented on PR #382: URL: https://github.com/apache/httpcomponents-core/pull/382#issuecomment-1415913414 Superseded by #384. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [httpcomponents-core] dependabot[bot] closed pull request #382: Bump mockito-core from 4.11.0 to 5.0.0

2023-02-03 Thread via GitHub
dependabot[bot] closed pull request #382: Bump mockito-core from 4.11.0 to 5.0.0 URL: https://github.com/apache/httpcomponents-core/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [httpcomponents-client] ok2c merged pull request #409: Remove unnecessary declarations.

2023-02-04 Thread via GitHub
ok2c merged PR #409: URL: https://github.com/apache/httpcomponents-client/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-client] ok2c commented on pull request #410: Bump mockito-core from 4.8.1 to 5.1.1

2023-02-04 Thread via GitHub
ok2c commented on PR #410: URL: https://github.com/apache/httpcomponents-client/pull/410#issuecomment-1416796929 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [httpcomponents-client] dependabot[bot] closed pull request #410: Bump mockito-core from 4.8.1 to 5.1.1

2023-02-04 Thread via GitHub
dependabot[bot] closed pull request #410: Bump mockito-core from 4.8.1 to 5.1.1 URL: https://github.com/apache/httpcomponents-client/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [httpcomponents-client] dependabot[bot] commented on pull request #410: Bump mockito-core from 4.8.1 to 5.1.1

2023-02-04 Thread via GitHub
dependabot[bot] commented on PR #410: URL: https://github.com/apache/httpcomponents-client/pull/410#issuecomment-1416796935 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. 😢 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #385: Replace lambdas with method references.

2023-02-05 Thread via GitHub
arturobernalg opened a new pull request, #385: URL: https://github.com/apache/httpcomponents-core/pull/385 Method references are more clear and readable compared to. Of course this could be a matter of taste. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutpu

2023-02-05 Thread via GitHub
arturobernalg opened a new pull request, #386: URL: https://github.com/apache/httpcomponents-core/pull/386 Again, this could be a matter of taste. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [httpcomponents-client] alicejli opened a new pull request, #411: Update Apache Commons Codec from 1.11 to 1.15.

2023-02-06 Thread via GitHub
alicejli opened a new pull request, #411: URL: https://github.com/apache/httpcomponents-client/pull/411 There was a vulnerability found with commons-codec (https://sca.analysiscenter.veracode.com/vulnerability-database/security/sca/vulnerability/sid-22742/summary) that was fixed in v1.13.

[GitHub] [httpcomponents-client] suztomo commented on pull request #299: Updating project URL to include '-ga' suffix

2023-02-06 Thread via GitHub
suztomo commented on PR #299: URL: https://github.com/apache/httpcomponents-client/pull/299#issuecomment-1419206346 Now it's fixed https://search.maven.org/artifact/org.apache.httpcomponents/httpclient/4.5.14/jar -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [httpcomponents-client] suztomo commented on pull request #411: Update Apache Commons Codec from 1.11 to 1.15.

2023-02-06 Thread via GitHub
suztomo commented on PR #411: URL: https://github.com/apache/httpcomponents-client/pull/411#issuecomment-1419665045 You talked about Java 6 compatibility. Can you write down findings here? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [httpcomponents-client] ok2c commented on pull request #411: Update Apache Commons Codec from 1.11 to 1.15.

2023-02-06 Thread via GitHub
ok2c commented on PR #411: URL: https://github.com/apache/httpcomponents-client/pull/411#issuecomment-1419700281 @alicejli We cannot upgrade HttpClient 4.5.x to the latest Commons Codec version due to Java 1.6 compatibility. Commons folks did not consider the security issue severe enough t

[GitHub] [httpcomponents-client] ok2c closed pull request #411: Update Apache Commons Codec from 1.11 to 1.15.

2023-02-06 Thread via GitHub
ok2c closed pull request #411: Update Apache Commons Codec from 1.11 to 1.15. URL: https://github.com/apache/httpcomponents-client/pull/411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [httpcomponents-client] alicejli commented on pull request #411: Update Apache Commons Codec from 1.11 to 1.15.

2023-02-06 Thread via GitHub
alicejli commented on PR #411: URL: https://github.com/apache/httpcomponents-client/pull/411#issuecomment-1419788638 Thank you for clarifying - that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [httpcomponents-core] ok2c commented on pull request #384: Bump mockito-core from 4.11.0 to 5.1.1

2023-02-08 Thread via GitHub
ok2c commented on PR #384: URL: https://github.com/apache/httpcomponents-core/pull/384#issuecomment-1422407973 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [httpcomponents-core] dependabot[bot] closed pull request #384: Bump mockito-core from 4.11.0 to 5.1.1

2023-02-08 Thread via GitHub
dependabot[bot] closed pull request #384: Bump mockito-core from 4.11.0 to 5.1.1 URL: https://github.com/apache/httpcomponents-core/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [httpcomponents-core] dependabot[bot] commented on pull request #384: Bump mockito-core from 4.11.0 to 5.1.1

2023-02-08 Thread via GitHub
dependabot[bot] commented on PR #384: URL: https://github.com/apache/httpcomponents-core/pull/384#issuecomment-1422408027 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. 😢 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [httpcomponents-core] ok2c commented on pull request #387: Added ViaRequest interceptor

2023-02-08 Thread via GitHub
ok2c commented on PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#issuecomment-1422421657 @arturobernalg Please change the target branch to `5.3.x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [httpcomponents-core] ok2c commented on pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutputStream()

2023-02-08 Thread via GitHub
ok2c commented on PR #386: URL: https://github.com/apache/httpcomponents-core/pull/386#issuecomment-1422427841 @arturobernalg 1. Please change the target branch to `5.3.x`. 2. I see 2 more instances of `new File*Stream`. Please replace them as well. -- This is an automated message from t

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutput

2023-02-08 Thread via GitHub
arturobernalg commented on PR #386: URL: https://github.com/apache/httpcomponents-core/pull/386#issuecomment-1423181592 > @arturobernalg 1. Please change the target branch to `5.3.x`. 2. I see 2 more instances of `new File*Stream`. Please replace them as well. @ok2c Done -- This i

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #387: Added ViaRequest interceptor

2023-02-08 Thread via GitHub
arturobernalg commented on PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#issuecomment-1423181889 > @arturobernalg Please change the target branch to `5.3.x`. @ok2c Done -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [httpcomponents-core] ok2c closed pull request #310: 5.2.x java time session and deadline

2023-02-09 Thread via GitHub
ok2c closed pull request #310: 5.2.x java time session and deadline URL: https://github.com/apache/httpcomponents-core/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [httpcomponents-core] ok2c closed pull request #350: HTTPCLIENT-2185 Add support for IDNA 2008 (RFC 5891)

2023-02-09 Thread via GitHub
ok2c closed pull request #350: HTTPCLIENT-2185 Add support for IDNA 2008 (RFC 5891) URL: https://github.com/apache/httpcomponents-core/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-09 Thread via GitHub
ok2c commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1101928433 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,122 @@ +/* + * =

[GitHub] [httpcomponents-core] ok2c commented on pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutputStream()

2023-02-09 Thread via GitHub
ok2c commented on PR #386: URL: https://github.com/apache/httpcomponents-core/pull/386#issuecomment-1424708225 @arturobernalg I am sorry I only now realized that the new APIs work with `Path` values and therefore entail an overhead of an extra conversion from `File` to `Path`. I do not th

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
arturobernalg commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1102450295 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,122 @@ +/* + *

[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #388: Fix the issue with invalid scoped IPv6 addresses in InetAddressUtils.

2023-02-10 Thread via GitHub
arturobernalg opened a new pull request, #388: URL: https://github.com/apache/httpcomponents-core/pull/388 This Pull Request addresses the issue of properly handling scoped IPv6 addresses in the InetAddressUtils class. The previous implementation had incorrect behavior when handling scoped

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
ok2c commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1102694216 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,127 @@ +/* + * =

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
ok2c commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1102694216 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,127 @@ +/* + * =

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #388: Fix the issue with invalid scoped IPv6 addresses in InetAddressUtils.

2023-02-10 Thread via GitHub
ok2c commented on code in PR #388: URL: https://github.com/apache/httpcomponents-core/pull/388#discussion_r1102701888 ## httpcore5/src/main/java/org/apache/hc/core5/net/InetAddressUtils.java: ## @@ -139,7 +152,32 @@ public static boolean isIPv6HexCompressedAddress(final String

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
arturobernalg commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1102703920 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,127 @@ +/* + *

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
arturobernalg commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1102703920 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,127 @@ +/* + *

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
ok2c commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1102705147 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,127 @@ +/* + * =

[GitHub] [httpcomponents-core] ok2c merged pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
ok2c merged PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #387: Added ViaRequest interceptor

2023-02-10 Thread via GitHub
ok2c commented on code in PR #387: URL: https://github.com/apache/httpcomponents-core/pull/387#discussion_r1102712447 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ViaRequest.java: ## @@ -0,0 +1,122 @@ +/* + * =

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #388: Fix the issue with invalid scoped IPv6 addresses in InetAddressUtils.

2023-02-10 Thread via GitHub
arturobernalg commented on code in PR #388: URL: https://github.com/apache/httpcomponents-core/pull/388#discussion_r1102728702 ## httpcore5/src/main/java/org/apache/hc/core5/net/InetAddressUtils.java: ## @@ -139,7 +152,32 @@ public static boolean isIPv6HexCompressedAddress(fina

[GitHub] [httpcomponents-core] arturobernalg closed pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutputStream

2023-02-10 Thread via GitHub
arturobernalg closed pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutputStream() calls respectively. URL: https://github.com/apache/httpcomponents-core/pull/386 -- This is an automated message from the

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #386: Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutput

2023-02-10 Thread via GitHub
arturobernalg commented on PR #386: URL: https://github.com/apache/httpcomponents-core/pull/386#issuecomment-1425765754 > @arturobernalg I am sorry I only now realized that the new APIs work with `Path` values and therefore entail an overhead of an extra conversion from `File` to `Path`. I

[GitHub] [httpcomponents-core] dependabot[bot] opened a new pull request, #389: Bump docker-maven-plugin from 0.31.0 to 0.41.0

2023-02-10 Thread via GitHub
dependabot[bot] opened a new pull request, #389: URL: https://github.com/apache/httpcomponents-core/pull/389 Bumps [docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin) from 0.31.0 to 0.41.0. Release notes Sourced from https://github.com/fabric8io/docker-maven-pl

[GitHub] [httpcomponents-core] dependabot[bot] commented on pull request #379: Bump docker-maven-plugin from 0.31.0 to 0.40.3

2023-02-10 Thread via GitHub
dependabot[bot] commented on PR #379: URL: https://github.com/apache/httpcomponents-core/pull/379#issuecomment-1425924067 Superseded by #389. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [httpcomponents-core] dependabot[bot] closed pull request #379: Bump docker-maven-plugin from 0.31.0 to 0.40.3

2023-02-10 Thread via GitHub
dependabot[bot] closed pull request #379: Bump docker-maven-plugin from 0.31.0 to 0.40.3 URL: https://github.com/apache/httpcomponents-core/pull/379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [httpcomponents-core] ok2c commented on pull request #388: Fix the issue with invalid scoped IPv6 addresses in InetAddressUtils.

2023-02-10 Thread via GitHub
ok2c commented on PR #388: URL: https://github.com/apache/httpcomponents-core/pull/388#issuecomment-1425939043 @arturobernalg Could you please change the target branch to 5.3.x? Otherwise looks good. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [httpcomponents-core] ok2c merged pull request #388: Fix the issue with invalid scoped IPv6 addresses in InetAddressUtils.

2023-02-10 Thread via GitHub
ok2c merged PR #388: URL: https://github.com/apache/httpcomponents-core/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-12 Thread via GitHub
arturobernalg opened a new pull request, #390: URL: https://github.com/apache/httpcomponents-core/pull/390 This pull request adds support for the Forwarded header to improve debugging, statistics, and location-dependent content generation. The Forwarded header contains information added by

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-13 Thread via GitHub
ok2c commented on code in PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#discussion_r1104408830 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ForwardedRequest.java: ## @@ -0,0 +1,159 @@ +/* + * ===

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-13 Thread via GitHub
arturobernalg commented on code in PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#discussion_r1104989176 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ForwardedRequest.java: ## @@ -0,0 +1,159 @@ +/* + * ==

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-14 Thread via GitHub
ok2c commented on code in PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#discussion_r1105457831 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ForwardedRequest.java: ## @@ -0,0 +1,159 @@ +/* + * ===

[GitHub] [httpcomponents-core] ok2c commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-14 Thread via GitHub
ok2c commented on PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1430290363 @arturobernalg One more thing. The javadocs say ``` The Forwarded header is added to the request by calling the `HttpRequest.addHeader` method. If a Forwarded header alr

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-14 Thread via GitHub
arturobernalg commented on PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1430330009 > @arturobernalg One more thing. The javadocs say > > ``` > The Forwarded header is added to the request by calling the `HttpRequest.addHeader` method. If a

[GitHub] [httpcomponents-core] asfgit merged pull request #375: Use either US-ASCII or UTF-8 encoding for text where approriate

2023-02-14 Thread via GitHub
asfgit merged PR #375: URL: https://github.com/apache/httpcomponents-core/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-core] ok2c commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-15 Thread via GitHub
ok2c commented on PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1431744979 @arturobernalg I am still not entirely sure I fully understand the intent of this interceptor. Is it meant to be used by (1) the client to populate the forwarded value for the ver

[GitHub] [httpcomponents-client] ok2c merged pull request #412: Updated NOTICE to 2023

2023-02-16 Thread via GitHub
ok2c merged PR #412: URL: https://github.com/apache/httpcomponents-client/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-core] hooyantsing opened a new pull request, #391: The official document POST example incorrectly calls the GET method

2023-02-17 Thread via GitHub
hooyantsing opened a new pull request, #391: URL: https://github.com/apache/httpcomponents-core/pull/391 The official document POST example incorrectly calls the GET method. For beginners, it is necessary to revise. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [httpcomponents-core] ok2c merged pull request #391: The official document POST example incorrectly calls the GET method

2023-02-17 Thread via GitHub
ok2c merged PR #391: URL: https://github.com/apache/httpcomponents-core/pull/391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-client] alicejli opened a new pull request, #413: chore: update ClientProxyAuthenticationExample

2023-02-17 Thread via GitHub
alicejli opened a new pull request, #413: URL: https://github.com/apache/httpcomponents-client/pull/413 Update to the `ClientAuthenticationProxy` example to be runnable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [httpcomponents-client] ok2c merged pull request #413: chore: update ClientProxyAuthenticationExample

2023-02-17 Thread via GitHub
ok2c merged PR #413: URL: https://github.com/apache/httpcomponents-client/pull/413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-18 Thread via GitHub
arturobernalg commented on PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1435763945 I did the necessary change to be complies to the RFC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-19 Thread via GitHub
ok2c commented on code in PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#discussion_r211537 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ForwardedRequest.java: ## @@ -0,0 +1,189 @@ +/* + * ===

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-19 Thread via GitHub
arturobernalg commented on PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1436048764 HI @ok2c I just commit all the change that you suggested. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [httpcomponents-core] ok2c commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-20 Thread via GitHub
ok2c commented on PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1436996145 @arturobernalg Almost there. Now consider the case when the `EndpointDetails` is null (not present in the execution context). What `forwarded` value would the interceptor produce?

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-20 Thread via GitHub
arturobernalg commented on PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390#issuecomment-1437551170 > @arturobernalg Almost there. Now consider the case when the `EndpointDetails` is null (not present in the execution context). What `forwarded` value would the intercept

[GitHub] [httpcomponents-core] ok2c merged pull request #390: Add a "Forwarded" HttpRequestInterceptor to add the "Forwarded" HTTP header.

2023-02-21 Thread via GitHub
ok2c merged PR #390: URL: https://github.com/apache/httpcomponents-core/pull/390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-core] jkmcl opened a new pull request, #392: Hygiene changes to Deadline

2023-02-22 Thread via GitHub
jkmcl opened a new pull request, #392: URL: https://github.com/apache/httpcomponents-core/pull/392 Since this is the v5.3 branch which is in alpha stage, is it fine to break binary compatibility by making Deadline.MIN_VALUE and Deadline.MAX_VALUE final and removing the checked exception fro

[GitHub] [httpcomponents-client] ok2c closed pull request #414: Hygiene - remove unused private fields

2023-02-23 Thread via GitHub
ok2c closed pull request #414: Hygiene - remove unused private fields URL: https://github.com/apache/httpcomponents-client/pull/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [httpcomponents-client] ok2c commented on pull request #414: Hygiene - remove unused private fields

2023-02-23 Thread via GitHub
ok2c commented on PR #414: URL: https://github.com/apache/httpcomponents-client/pull/414#issuecomment-1441632884 @jkmcl It cannot be done until 6.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [httpcomponents-client] ok2c merged pull request #414: Hygiene - remove unused private fields

2023-02-23 Thread via GitHub
ok2c merged PR #414: URL: https://github.com/apache/httpcomponents-client/pull/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-client] dependabot[bot] opened a new pull request, #415: Bump log4j.version from 2.19.0 to 2.20.0

2023-02-24 Thread via GitHub
dependabot[bot] opened a new pull request, #415: URL: https://github.com/apache/httpcomponents-client/pull/415 Bumps `log4j.version` from 2.19.0 to 2.20.0. Updates `log4j-slf4j-impl` from 2.19.0 to 2.20.0 Commits https://github.com/apache/logging-log4j2/commit/44ab0131718fc8d

[GitHub] [httpcomponents-core] dependabot[bot] opened a new pull request, #393: Bump log4j.version from 2.19.0 to 2.20.0

2023-02-24 Thread via GitHub
dependabot[bot] opened a new pull request, #393: URL: https://github.com/apache/httpcomponents-core/pull/393 Bumps `log4j.version` from 2.19.0 to 2.20.0. Updates `log4j-slf4j-impl` from 2.19.0 to 2.20.0 Commits https://github.com/apache/logging-log4j2/commit/44ab0131718fc8d1f

[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #394: Add support for Internationalized Domain Names (IDN)

2023-02-24 Thread via GitHub
arturobernalg opened a new pull request, #394: URL: https://github.com/apache/httpcomponents-core/pull/394 Improve IDN support in URI parsing by converting non-ASCII characters to their ASCII-compatible form using the java.net.IDN class. This allows for better interoperability with systems

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #394: Add support for Internationalized Domain Names (IDN)

2023-02-24 Thread via GitHub
ok2c commented on code in PR #394: URL: https://github.com/apache/httpcomponents-core/pull/394#discussion_r1117710747 ## httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java: ## @@ -141,4 +141,22 @@ public static String toLowerCase(final String s) { return s

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #394: Add support for Internationalized Domain Names (IDN)

2023-02-24 Thread via GitHub
arturobernalg commented on code in PR #394: URL: https://github.com/apache/httpcomponents-core/pull/394#discussion_r1117720198 ## httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java: ## @@ -141,4 +141,22 @@ public static String toLowerCase(final String s) {

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #394: Add support for Internationalized Domain Names (IDN)

2023-02-24 Thread via GitHub
arturobernalg commented on PR #394: URL: https://github.com/apache/httpcomponents-core/pull/394#issuecomment-1444581097 I just change the branch base to 5.3.x and use CharSequence instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [httpcomponents-core] ok2c merged pull request #394: Add support for Internationalized Domain Names (IDN)

2023-02-25 Thread via GitHub
ok2c merged PR #394: URL: https://github.com/apache/httpcomponents-core/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-client] ok2c merged pull request #416: Remove dependency not used

2023-02-25 Thread via GitHub
ok2c merged PR #416: URL: https://github.com/apache/httpcomponents-client/pull/416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-core] ok2c commented on pull request #392: Hygiene changes to Deadline

2023-02-25 Thread via GitHub
ok2c commented on PR #392: URL: https://github.com/apache/httpcomponents-core/pull/392#issuecomment-1445031389 @jkmcl This cannot be done until 6.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [httpcomponents-core] ok2c closed pull request #392: Hygiene changes to Deadline

2023-02-25 Thread via GitHub
ok2c closed pull request #392: Hygiene changes to Deadline URL: https://github.com/apache/httpcomponents-core/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [httpcomponents-client] arturobernalg opened a new pull request, #417: Fix Heuristic caching for URIs with query strings by adhering to RFC …

2023-02-27 Thread via GitHub
arturobernalg opened a new pull request, #417: URL: https://github.com/apache/httpcomponents-client/pull/417 This pull request addresses the issue where heuristic caching was not working for URIs with query strings. The problem arises from Section 13.9 of RFC 2616, which prohibits caches fr

[GitHub] [httpcomponents-client] arturobernalg opened a new pull request, #418: Fix issue with LLv6 literals in URLs

2023-02-28 Thread via GitHub
arturobernalg opened a new pull request, #418: URL: https://github.com/apache/httpcomponents-client/pull/418 This pull request addresses issue LLv6 literals in URLs, where LLv6 literals in URLs are not properly handled by HttpClient due to a limitation in the Java standard method InetAddres

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-01 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1121977585 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,14 @@ public class SystemDefaultDnsResolver implements

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-01 Thread via GitHub
arturobernalg commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r119616 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,14 @@ public class SystemDefaultDnsResolver im

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-01 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1122259452 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,14 @@ public class SystemDefaultDnsResolver implements

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-01 Thread via GitHub
arturobernalg commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1122275420 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,14 @@ public class SystemDefaultDnsResolver im

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-02 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1123306774 ## httpclient5/src/test/java/org/apache/hc/client5/http/SystemDefaultDnsResolverTest.java: ## @@ -0,0 +1,68 @@ +/* + * ===

[GitHub] [httpcomponents-client] arturobernalg commented on pull request #418: Fix issue with LLv6 literals in URLs

2023-03-02 Thread via GitHub
arturobernalg commented on PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#issuecomment-1452512057 HI @ok2c Even though I don't fully agree with putting logic in the catch block, I made the change. I believe it's better to keep it separate." TY -- This is an

[GitHub] [httpcomponents-core] dependabot[bot] opened a new pull request, #395: Bump docker-maven-plugin from 0.31.0 to 0.42.0

2023-03-03 Thread via GitHub
dependabot[bot] opened a new pull request, #395: URL: https://github.com/apache/httpcomponents-core/pull/395 Bumps [docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin) from 0.31.0 to 0.42.0. Release notes Sourced from https://github.com/fabric8io/docker-maven-pl

[GitHub] [httpcomponents-core] dependabot[bot] closed pull request #389: Bump docker-maven-plugin from 0.31.0 to 0.41.0

2023-03-03 Thread via GitHub
dependabot[bot] closed pull request #389: Bump docker-maven-plugin from 0.31.0 to 0.41.0 URL: https://github.com/apache/httpcomponents-core/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [httpcomponents-core] dependabot[bot] commented on pull request #389: Bump docker-maven-plugin from 0.31.0 to 0.41.0

2023-03-03 Thread via GitHub
dependabot[bot] commented on PR #389: URL: https://github.com/apache/httpcomponents-core/pull/389#issuecomment-1453655727 Superseded by #395. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-03 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1124684449 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,23 @@ public class SystemDefaultDnsResolver implements

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-03 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1124684449 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,23 @@ public class SystemDefaultDnsResolver implements

[GitHub] [httpcomponents-client] ok2c commented on pull request #417: Fix Heuristic caching for URIs with query strings by adhering to RFC …

2023-03-03 Thread via GitHub
ok2c commented on PR #417: URL: https://github.com/apache/httpcomponents-client/pull/417#issuecomment-1453773882 If there are no objections or other reviews I will merge this PR in a day or two. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-03 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1124702424 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,23 @@ public class SystemDefaultDnsResolver implements

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-03 Thread via GitHub
arturobernalg commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1124799194 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,23 @@ public class SystemDefaultDnsResolver im

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-03 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1124887617 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,23 @@ public class SystemDefaultDnsResolver implements

[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-03 Thread via GitHub
arturobernalg commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1124939005 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,23 @@ public class SystemDefaultDnsResolver im

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #418: Fix issue with LLv6 literals in URLs

2023-03-03 Thread via GitHub
ok2c commented on code in PR #418: URL: https://github.com/apache/httpcomponents-client/pull/418#discussion_r1124960216 ## httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java: ## @@ -40,7 +40,23 @@ public class SystemDefaultDnsResolver implements

[GitHub] [httpcomponents-client] arturobernalg opened a new pull request, #419: Fix calculation of freshness lifetime in HttpResponse

2023-03-04 Thread via GitHub
arturobernalg opened a new pull request, #419: URL: https://github.com/apache/httpcomponents-client/pull/419 This pull request adds a fix for the calculateFreshnessLifetime method in the HttpResponseCache class. The method calculates the freshness lifetime of a response based on the headers

  1   2   3   4   5   6   7   8   9   10   >